11626 - [PP]Context menus are broken

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Robert John Churchill]

Context menus seem broken. They were working a few days ago.

As an example, try this:  run apprunner, select "Bookmarks | Manage Bookmarks".
You'll get the bookmarks window. Click on a node to select it, then right-mouse
click (or, on the Mac, ctrl-key+click) on it to bring up a context menu. It has
crap in it.

Comment 1

[Robert John Churchill]

Chris, is there any chance of getting this bug fixed for M9?

Comment 2

[David Hyatt]

Robert, I suspect you are building the menu using "onclick" attributes instead
of "onaction" attributes.  I changed the syntax a week or two ago, and I
probably missed your stuff, since it presumably is built in C++ or JS code
rather than being specified in the XUL.

Comment 3

[Robert John Churchill]

The problem seems to be in setting the "name" attribute, such as:

menuItem.setAttribute("name", cmdName);

Has that changed to something else?

Comment 4

[David Hyatt]

Oh, and more importantly "name" became "value".

Comment 5

[Robert John Churchill]

Yep, that fixes it.  :^)  Thanks, Chris.  I'll take ownership of this bug back,
to get it off of your radar.

Chris (Hoffman), I'd like check-in permission to fix this for M9. The fix
consists of two changes to strings in a JavaScript file.  Pretty trivial.

Comment 6

[chris hofmann]

ok,  get a review and wait for mac bustage to clear tonight,
or after the verfication builds are done on tuesday..

Comment 7

[David Hyatt]

i can supply a review right now.

Comment 8

[Robert John Churchill]

David, here is the diff:

<         menuItem.setAttribute("name", cmdName);
<         menuItem.setAttribute("onclick", "return doContextCmd('" +
cmdResource.Value + "');");

---

>         menuItem.setAttribute("value", cmdName);
>         menuItem.setAttribute("onaction", "return doContextCmd('"
+ cmdResource.Value + "');");

Comment 9

[David Hyatt]

Looks good.  This change is safe and trivial.  I vote for checking it in when
the Mac bustage gets cleared up.  Does that sound good, Chris (H)?

Comment 10

[chris hofmann]

do it!

Comment 11

[Robert John Churchill]

Fixed checked in.

Comment 12

[Claudius Gayle]

works perfectly on WinNT with 1999081308 builds was this an XP problem originally?
I ask because they don't work on linux and the debug console has a lot to say when you try
I'm blocked by bug 11832 from checking on mac unless you can tell me where else to do a
context click that doesn't involve bookmarks or history.
As a matter of fact, I'm going to REOPEN this until answered.

Comment 13

[Robert John Churchill]

If context menus don't work on Linux, this bug needs to be pointed at the one
working on implementing them.  I think that's probably Chris Saari... so
reassigning to him.

Comment 14

[Claudius Gayle]

I still can't verify if this is fixed on Mac, marking PP linux for now though
since they are working on WinNT.

Comment 15

[saari (gone)]

Pavlov is the last man standing on linux context/popups... CC'ing him

Comment 16

[Stuart Parmenter]

this is a duplicate of another bug if we are saying they don't work on linux.
this has been pushed off until we have XP context menus.

Comment 17

[leger]

We know that context menus will not be fixed for M9 and this info is on the
"most frequent bugs page".  MOving to M10

Comment 18

[saari (gone)]

Giving this to hyatt so he can close it when the popup rearchitecting is done

Comment 19

[Peter Trudelle]

resolved as fixed

Comment 20

[Paul MacQuiddy]

Yes, I see context menus in Linux working OK on M10 builds

Comment 21

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.