typo in Debugger.Script.md

RESOLVED FIXED in Firefox 59

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: tromey, Unassigned)

Tracking

Other Branch
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Debugger.Script.md says:

<code>clearBreakpoints(handler, [<i>offset</i>])</code>

But the code says:

    JS_FN("clearBreakpoint", DebuggerScript_clearBreakpoint, 1, 0),

That is, the documentation has an extra "s" in the function name.

Comment 1

2 months ago
Can I take this over?

Comment 2

2 months ago
Created attachment 8934392 [details] [diff] [review]
Bug-1162614.patch
Attachment #8934392 - Flags: review?(ttromey)
(Reporter)

Comment 3

2 months ago
Comment on attachment 8934392 [details] [diff] [review]
Bug-1162614.patch

Review of attachment 8934392 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch.  This looks good to me.
Attachment #8934392 - Flags: review?(ttromey) → review+
(Reporter)

Comment 4

2 months ago
I think that this doesn't need a try run.
So, the thing to do is put "DONTBUILD" into the commit message's first line, like

Bug - 1162614 : changed 'clearBreakpoints(handler, [<i>offset</i>])' to 'clearBreakpoint(handler, [<i>offset</i>])'; DONTBUILD, r=tromey

... actually I would reword that a little and (1) remove the "-" and (2) make the subject a little less wordy, like:

Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD, r=tromey

Once you've done this we can set the "checkin-needed" flag.

Thanks!
(Reporter)

Comment 5

2 months ago
Actually dholbert pointed out that I ought to just land this myself.
So I'll do that in a bit.  You don't have to update the commit message, I'll handle that.
(Reporter)

Comment 6

2 months ago
Apparently I've lost my direct push authorization due to disuse.
So I'm going to try autoland instead.
Comment hidden (mozreview-request)
(Reporter)

Comment 8

2 months ago
mozreview-review
Comment on attachment 8934569 [details]
Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD,

https://reviewboard.mozilla.org/r/205464/#review211072
Attachment #8934569 - Flags: review?(ttromey) → review+

Comment 9

2 months ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eba7de6b450
fix incorrect function name in Debugger.Script.md; DONTBUILD, r=tromey
(Reporter)

Updated

2 months ago
Attachment #8934392 - Attachment is obsolete: true

Comment 10

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1eba7de6b450
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.