Closed
Bug 1162614
Opened 9 years ago
Closed 7 years ago
typo in Debugger.Script.md
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
Details
Attachments
(1 file, 1 obsolete file)
Debugger.Script.md says: <code>clearBreakpoints(handler, [<i>offset</i>])</code> But the code says: JS_FN("clearBreakpoint", DebuggerScript_clearBreakpoint, 1, 0), That is, the documentation has an extra "s" in the function name.
Comment 1•7 years ago
|
||
Can I take this over?
Comment 2•7 years ago
|
||
Attachment #8934392 -
Flags: review?(ttromey)
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8934392 [details] [diff] [review] Bug-1162614.patch Review of attachment 8934392 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for the patch. This looks good to me.
Attachment #8934392 -
Flags: review?(ttromey) → review+
Assignee | ||
Comment 4•7 years ago
|
||
I think that this doesn't need a try run. So, the thing to do is put "DONTBUILD" into the commit message's first line, like Bug - 1162614 : changed 'clearBreakpoints(handler, [<i>offset</i>])' to 'clearBreakpoint(handler, [<i>offset</i>])'; DONTBUILD, r=tromey ... actually I would reword that a little and (1) remove the "-" and (2) make the subject a little less wordy, like: Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD, r=tromey Once you've done this we can set the "checkin-needed" flag. Thanks!
Assignee | ||
Comment 5•7 years ago
|
||
Actually dholbert pointed out that I ought to just land this myself. So I'll do that in a bit. You don't have to update the commit message, I'll handle that.
Assignee | ||
Comment 6•7 years ago
|
||
Apparently I've lost my direct push authorization due to disuse. So I'm going to try autoland instead.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8934569 [details] Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD, https://reviewboard.mozilla.org/r/205464/#review211072
Attachment #8934569 -
Flags: review?(ttromey) → review+
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eba7de6b450 fix incorrect function name in Debugger.Script.md; DONTBUILD, r=tromey
Assignee | ||
Updated•7 years ago
|
Attachment #8934392 -
Attachment is obsolete: true
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1eba7de6b450
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•6 years ago
|
Assignee: nobody → ttromey
You need to log in
before you can comment on or make changes to this bug.
Description
•