1162614 - typo in Debugger.Script.md

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Tromey :tromey]

Debugger.Script.md says:

<code>clearBreakpoints(handler, [<i>offset</i>])</code>

But the code says:

    JS_FN("clearBreakpoint", DebuggerScript_clearBreakpoint, 1, 0),

That is, the documentation has an extra "s" in the function name.

Comment 1

[manikishanghantasala]

Can I take this over?

Comment 2

[manikishanghantasala]

Attachment: Bug-1162614.patch

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8934392 [details] [diff] [review]
Bug-1162614.patch

Review of attachment 8934392 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch.  This looks good to me.

Comment 4

[Tom Tromey :tromey]

I think that this doesn't need a try run.
So, the thing to do is put "DONTBUILD" into the commit message's first line, like

Bug - 1162614 : changed 'clearBreakpoints(handler, [<i>offset</i>])' to 'clearBreakpoint(handler, [<i>offset</i>])'; DONTBUILD, r=tromey

... actually I would reword that a little and (1) remove the "-" and (2) make the subject a little less wordy, like:

Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD, r=tromey

Once you've done this we can set the "checkin-needed" flag.

Thanks!

Comment 5

[Tom Tromey :tromey]

Actually dholbert pointed out that I ought to just land this myself.
So I'll do that in a bit.  You don't have to update the commit message, I'll handle that.

Comment 6

[Tom Tromey :tromey]

Apparently I've lost my direct push authorization due to disuse.
So I'm going to try autoland instead.

Comment 7

[Tom Tromey :tromey]

Attachment: Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD,

Review commit: https://reviewboard.mozilla.org/r/205464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205464/

Comment 8

[Tom Tromey :tromey]

Comment on attachment 8934569 [details]
Bug 1162614 - fix incorrect function name in Debugger.Script.md; DONTBUILD,

https://reviewboard.mozilla.org/r/205464/#review211072

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eba7de6b450
fix incorrect function name in Debugger.Script.md; DONTBUILD, r=tromey

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1eba7de6b450