1162697 - spinner when saving to pocket feels like a responsiveness problem

Status: RESOLVED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Madhava Enros [:madhava]]

When I hit the Pocket button in Nightly, I get an empty panel with only a spinner while the page is saved to pocket.

No other panel in Firefox does this, and the result is that it feels like I'm waiting for the panel content to load (which makes it feel broken).

In fact, the panel _is_ doing something -- it's saving. If there were some content in the panel other than spinner (i.e. "Saving to Pocket!" with an icon), then the user would know that something is actually happening.

Comment 1

[Jeff Beatty [:gueroJeff]]

"Saving..." would be best, since it could be reused from https://transvision.mozfr.org/?sourcelocale=en-US&locale=es-AR&repo=aurora&search_type=entities&recherche=browser/chrome/browser/devtools/canvasdebugger.properties:snapshotsList.savingLabel .

Comment 2

[Axel Hecht [:Pike]]

Can we code this such that it only shows the spinner when there's no translation available?

That way, we can make this fix totally incremental.

Comment 3

[chris hofmann]

(In reply to Jeff Beatty [:gueroJeff] from comment #1)
> "Saving..." would be best, since it could be reused from
> https://transvision.mozfr.org/?sourcelocale=en-US&locale=es-
> AR&repo=aurora&search_type=entities&recherche=browser/chrome/browser/
> devtools/canvasdebugger.properties:snapshotsList.savingLabel .


To expand a bit on this...

If we want to get this turned around quickly on the localization side
lets make this as simple as possible.  If we show the pocket logo, 
the spinner, and say "Saving" like in the screen shot I saw is that 
good enough?

Also need to confirm that reuse of "Saving..."  actually works for 
the 4 locales that we are talkng about, but right now it looks lie 
we should be able to re-use from transvision if we go with this 
revised plan. 

Pike's idea in comment 4 would be another approach at a work around 
for localization if it turns out re-use of strings in this case 
has problems.

Comment 4

[Nate Weiner]

A new design for this state is coming in tonight's code drop to the FF team. 

You can see what it looks like here:
https://www.dropbox.com/s/a8wdz4lt095ee1b/saving_plus_spinner-1.png?dl=0

Comment 5

[Nate Weiner]

Also: The strings were handed off to Bryan so I believe that's already covered.

Comment 6

[Madhava Enros [:madhava]]

Looks great!

(In reply to Nate Weiner from comment #4)
> A new design for this state is coming in tonight's code drop to the FF team. 
> 
> You can see what it looks like here:
> https://www.dropbox.com/s/a8wdz4lt095ee1b/saving_plus_spinner-1.png?dl=0

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Looks like we can just use these strings:

https://mxr.mozilla.org/l10n-mozilla-release/search?string=snapshotsList.savingLabel&filter=%28ru|ja|es-ES|de%29%2Fbrowser

Comment 8

[Francesco Lodolo [:flod]]

https://transvision.mozfr.org/string/?entity=browser/chrome/browser/devtools/canvasdebugger.properties:snapshotsList.savingLabel&repo=release

or via API (link a the top)

https://transvision.mozfr.org/api/v1/entity/release/?id=browser/chrome/browser/devtools/canvasdebugger.properties:snapshotsList.savingLabel

Side note: since this is a string in devtools, don't get fooled by the amount of "Saving…", some locales simply copy over en-US to get rid of warnings about missing strings.

For the specific case (de, es-ES, ja-JP, ru), we're fine.

Comment 9

[Stuart Philp :sphilp]

looks to be resolved in nightly