1162703 - [skiplist] Add mozilla::ipc::MessageChannel::Send to prefix skiplist

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I'm not sure how the skiplist stuff works. But here's an example crash:
https://crash-stats.mozilla.com/report/index/918b1ecb-8a06-47b7-b66a-8a5442150430

The signature we get for this crash is:
mozalloc_abort(char const* const) | NS_DebugBreak | mozilla::ipc::MessageChannel::DebugAbort(char const*, int, char const*, char const*, bool) | mozilla::ipc::MessageChannel::Send(IPC::Message*, IPC::Message*)

I would prefer that instead the signature should be:
mozalloc_abort(char const* const) | NS_DebugBreak | mozilla::ipc::MessageChannel::DebugAbort(char const*, int, char const*, char const*, bool) | mozilla::ipc::MessageChannel::Send(IPC::Message*, IPC::Message*) | mozilla::dom::PBrowserChild::SendSyncMessage(nsString const&, mozilla::dom::ClonedMessageData const&, nsTArray<mozilla::jsipc::CpowEntry> const&, IPC::Principal const&, nsTArray<nsString>*)

The last function (SendSyncMessage) is really what distinguishes these crashes, so it makes sense to separate crashes based on it. Right now they're all grouped together and it's hard to get a sense of which message type causes the most trouble.

Comment 1

[Jim Mathies [:jimm]]

here's the mac signature which is similar.

mozalloc_abort(char const*) | Abort | NS_DebugBreak | mozilla::ipc::MessageChannel::DebugAbort(char const*, int, char const*, char const*, bool) const | mozilla::ipc::MessageChannel::Send(IPC::Message*, IPC::Message*)

https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2015-05-07&signature=mozalloc_abort%28char+const*%29+|+Abort+|+NS_DebugBreak+|+mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ADebugAbort%28char+const*%2C+int%2C+char+const*%2C+char+const*%2C+bool%29+const+|+mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ASend%28IPC%3A%3AMessage*%2C+IPC%3A%3AMessage*%29&version=Firefox%3A40.0a1#tab-reports

Comment 2

[Jim Mathies [:jimm]]

linux -

mozalloc_abort(char const*) | NS_DebugBreak | mozilla::ipc::MessageChannel::DebugAbort(char const*, int, char const*, char const*, bool) const | mozilla::ipc::MessageChannel::Send(IPC::Message*, IPC::Message*)

https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2015-05-07&signature=mozalloc_abort%28char+const*%29+|+NS_DebugBreak+|+mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ADebugAbort%28char+const*%2C+int%2C+char+const*%2C+char+const*%2C+bool%29+const+|+mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ASend%28IPC%3A%3AMessage*%2C+IPC%3A%3AMessage*%29&version=Firefox%3A40.0a1

Comment 3

[Jim Mathies [:jimm]]

windows - 

mozalloc_abort(char const* const) | NS_DebugBreak | mozilla::ipc::MessageChannel::DebugAbort(char const*, int, char const*, char const*, bool) | mozilla::ipc::MessageChannel::Send(IPC::Message*, IPC::Message*)

https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2015-05-07&signature=mozalloc_abort%28char+const*+const%29+|+NS_DebugBreak+|+mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ADebugAbort%28char+const*%2C+int%2C+char+const*%2C+char+const*%2C+bool%29+|+mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ASend%28IPC%3A%3AMessage*%2C+IPC%3A%3AMessage*%29&version=Firefox%3A40.0a1

Comment 4

[Robert Kaiser]

What we need here is to add mozilla::ipc::MessageChannel::Send to the prefix list, which means that when we encounter that frame, we'll add the next one after a | character, just like we already do for mozilla::ipc::MessageChannel::DebugAbort.

jimm, does that sounds right?

Lars, can you do that?

Comment 5

[Jim Mathies [:jimm]]

(In reply to Robert Kaiser (:[e-mail]) from comment #4)
> What we need here is to add mozilla::ipc::MessageChannel::Send to the prefix
> list, which means that when we encounter that frame, we'll add the next one
> after a | character, just like we already do for
> mozilla::ipc::MessageChannel::DebugAbort.
> 
> jimm, does that sounds right?

Yes we want to add the Send frame from each platform to the prefix list.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8ff508cea08180260fd091fa9efb1315e868ddf8
Merge pull request #2836 from twobraids/message_channel_send

Fixes Bug 1162703 - added mozilla::ipc::MessageChannel::Send to prefix

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF40 as this was mentioned in last week's channel meeting.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

I think this is now fixed. Please resubmit if it is not the case.

Comment 9

[Robert Kaiser]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> I think this is now fixed. Please resubmit if it is not the case.

I haven't seen a Socorro release being shipped since that was landed, so it's fixed on Socorro master, but not in production yet.

Comment 10

[Robert Kaiser]

This was shipped to production yesterday, the list for what was one signature on that branch before now looks like this: https://crash-stats.mozilla.com/search/?product=Firefox&signature=~mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3ASend&date=%3E2015-06-10+23%3A00%3A00&version=40.0a2&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature