Closed Bug 1162736 Opened 5 years ago Closed 5 years ago
Bottom toolbar briefly disappears after navigating away from about:home
47 bytes, text/x-github-pull-request
|Details | Review|
STR: 1) Go to about:home 2) Click a top site thumbnail The bottom navigation toolbar briefly disappears and then comes back.
So I notice the current behavior is that by default the Home Panel screen hides the toolbar. When the user navigates to a link, the toolbar appears. In the case of navigating to about:home, the toolbar is shown during the Home Panel then flickers away and comes back when you navigate. Should the Home Panel always display the toolbar?
Ah ignore that last comment. I see the issue now :)
Attachment #8605852 - Flags: review?(bnicholson) → feedback+
Doesn't seem to be an issue anymore on latest master. I think the change I made to the constraints on on the header/footer views in the past week resolved this issue. Let me know if you can reproduce it.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Still seeing this (what you described in comment 1, I think). Were you looking at something else in comment 2?
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Strange -- I'm seeing the issue in comment 1 as well now. I'll investigate.
Attachment #8605852 - Attachment is obsolete: true
Comment on attachment 8613690 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/535 Looks good to me. Not sure what the `url == AppConstants.AboutHomeURL` check was for...maybe an artifact that got left behind by refactoring at some point.
Attachment #8613690 - Flags: review?(bnicholson) → review+
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.