Closed
Bug 1162736
Opened 10 years ago
Closed 10 years ago
Bottom toolbar briefly disappears after navigating away from about:home
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: bnicholson, Assigned: sleroux)
Details
(Keywords: reproducible, Whiteboard: noteworthy)
Attachments
(1 file, 1 obsolete file)
STR:
1) Go to about:home
2) Click a top site thumbnail
The bottom navigation toolbar briefly disappears and then comes back.
|
||
Updated•10 years ago
|
Keywords: reproducible
|
||
Updated•10 years ago
|
Assignee: nobody → sleroux
tracking-fennec: ? → +
|
Assignee | |
Comment 1•10 years ago
|
||
So I notice the current behavior is that by default the Home Panel screen hides the toolbar. When the user navigates to a link, the toolbar appears. In the case of navigating to about:home, the toolbar is shown during the Home Panel then flickers away and comes back when you navigate. Should the Home Panel always display the toolbar?
|
|
Assignee | |
Comment 2•10 years ago
|
||
Ah ignore that last comment. I see the issue now :)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8605852 -
Flags: review?(bnicholson)
|
Reporter | |
Updated•10 years ago
|
Attachment #8605852 -
Flags: review?(bnicholson) → feedback+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Doesn't seem to be an issue anymore on latest master. I think the change I made to the constraints on on the header/footer views in the past week resolved this issue. Let me know if you can reproduce it.
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
|
|
Reporter | |
Comment 5•10 years ago
|
||
Still seeing this (what you described in comment 1, I think). Were you looking at something else in comment 2?
Status: RESOLVED → REOPENED
Flags: needinfo?(sleroux)
Resolution: WORKSFORME → ---
|
|
Assignee | |
Comment 6•10 years ago
|
||
Strange -- I'm seeing the issue in comment 1 as well now. I'll investigate.
Flags: needinfo?(sleroux)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Attachment #8613690 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8605852 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 8•10 years ago
|
||
Comment on attachment 8613690 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/535
Looks good to me. Not sure what the `url == AppConstants.AboutHomeURL` check was for...maybe an artifact that got left behind by refactoring at some point.
Attachment #8613690 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
Merged
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: noteworthy
You need to log in
before you can comment on or make changes to this bug.
Description
•