Closed
Bug 1162775
Opened 9 years ago
Closed 9 years ago
Make contentAreaDropListener.js use dataTransfer.files
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file, 1 obsolete file)
1.83 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently it attempts to get an nsIFile from the data transfer in order to get a URL for the dropped file. With sandboxing using an nsIFile in the content process may be difficult. Instead we should use dataTransfer.files but then we need a way to get a URL for a File. Currently the way we construct file: URIs revolves around nsIFile (net_GetURLSpecFromActualFile is the root and is platform specific).
Assignee | ||
Comment 1•9 years ago
|
||
I guess we do have a way to get a file URI without an nsIFile after all!
Comment 2•9 years ago
|
||
Comment on attachment 8604187 [details] [diff] [review] patch Interesting. Crossing fingers toFileURI does the right thing ;) It really should.
Attachment #8604187 -
Flags: review?(bugs) → review+
Backed out in https://hg.mozilla.org/integration/fx-team/rev/21158b018fb9 for bc1 orange: https://treeherder.mozilla.org/logviewer.html#?job_id=3045679&repo=fx-team
Flags: needinfo?(dtownsend)
Assignee | ||
Comment 5•9 years ago
|
||
Missed that files can sometimes be null.
Attachment #8604187 -
Attachment is obsolete: true
Flags: needinfo?(dtownsend)
Attachment #8605532 -
Flags: review?(bugs)
Comment 6•9 years ago
|
||
Comment on attachment 8605532 [details] [diff] [review] patch Sorry, I should have noticed that.
Attachment #8605532 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/34a03726e059
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/34a03726e059
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•