1162775 - Make contentAreaDropListener.js use dataTransfer.files

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Dave Townsend [:mossop]]

Currently it attempts to get an nsIFile from the data transfer in order to get a URL for the dropped file. With sandboxing using an nsIFile in the content process may be difficult. Instead we should use dataTransfer.files but then we need a way to get a URL for a File. Currently the way we construct file: URIs revolves around nsIFile (net_GetURLSpecFromActualFile is the root and is platform specific).

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

I guess we do have a way to get a file URI without an nsIFile after all!

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8604187 [details] [diff] [review]
patch

Interesting. Crossing fingers toFileURI does the right thing ;)
It really should.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fae12b6114b8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/21158b018fb9 for bc1 orange:

https://treeherder.mozilla.org/logviewer.html#?job_id=3045679&repo=fx-team

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch

Missed that files can sometimes be null.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8605532 [details] [diff] [review]
patch

Sorry, I should have noticed that.

Comment 7

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/34a03726e059

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34a03726e059