1162780 - Import NSPR 4.10.9 beta 2

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

We can't resolve bug 1133073 by getting rid of the local copy of PR_DuplicateEnvironment unless we can depend on having it available in NSPR.  It was added in what will be NSPR 4.10.9 beta 2 whenever that's tagged, but we don't want to break --with-system-nspr builds.

Currently only B2G and Android need PR_DuplicateEnvironment (and I think those always use Gecko's internal NSPR?), but there are plans to also use it on desktop Linux/Unix, and this also indirectly blocks that.

It would be possible to split this all up more (import NSPR 4.10.9 beta 2 → remove local PR_DuplicateEnvironment → require NSPR 4.10.9 final → unconditionalize use of PR_DuplicateEnvironment) if that would help.

Comment 1

[(not currently active) Ted Mielczarek]

Nah, this is fine. I'll tag NSPR tip for you and you can land the update. If you write the configure patch to bump the required NSPR version I'll review it.

Comment 2

[(not currently active) Ted Mielczarek]

I've tagged NSPR tip as NSPR_4_10_9_BETA2, you can use `python client.py update_nspr NSPR_4_10_9_BETA2` to pull that into the tree, r=me.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1162780-nspr-hg0.diff

Applying r=ted from comment #2.  Currently running Try, just in case.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Looks reasonable: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f73c92ee0337

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e65ce3ee7cde

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e65ce3ee7cde