Closed
Bug 1162780
Opened 10 years ago
Closed 9 years ago
Import NSPR 4.10.9 beta 2
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox40 affected, firefox42 fixed)
RESOLVED
FIXED
mozilla42
People
(Reporter: jld, Assigned: jld)
References
Details
Attachments
(1 file)
39.54 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
We can't resolve bug 1133073 by getting rid of the local copy of PR_DuplicateEnvironment unless we can depend on having it available in NSPR. It was added in what will be NSPR 4.10.9 beta 2 whenever that's tagged, but we don't want to break --with-system-nspr builds.
Currently only B2G and Android need PR_DuplicateEnvironment (and I think those always use Gecko's internal NSPR?), but there are plans to also use it on desktop Linux/Unix, and this also indirectly blocks that.
It would be possible to split this all up more (import NSPR 4.10.9 beta 2 → remove local PR_DuplicateEnvironment → require NSPR 4.10.9 final → unconditionalize use of PR_DuplicateEnvironment) if that would help.
Comment 1•10 years ago
|
||
Nah, this is fine. I'll tag NSPR tip for you and you can land the update. If you write the configure patch to bump the required NSPR version I'll review it.
Comment 2•10 years ago
|
||
I've tagged NSPR tip as NSPR_4_10_9_BETA2, you can use `python client.py update_nspr NSPR_4_10_9_BETA2` to pull that into the tree, r=me.
Assignee | ||
Updated•9 years ago
|
No longer blocks: 1133073
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Require NSPR ≥ 4.10.9 → Import NSPR 4.10.9 beta 2
Assignee | ||
Comment 3•9 years ago
|
||
Applying r=ted from comment #2. Currently running Try, just in case.
Assignee: nobody → jld
Attachment #8637358 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
Looks reasonable: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f73c92ee0337
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•