Closed Bug 1162901 Opened 9 years ago Closed 9 years ago

Fix sign comparison warnings in widget/gonk/BootAnimation.cpp

Categories

(Core Graveyard :: Widget: Gonk, defect)

Product:
Core Graveyard
Component:
Widget: Gonk
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: boris, Assigned: boris)

Details

Attachments

(1 file)

Fix warnings in BootAnimation (v1)
4.80 KB, patch
mwu
: review+
Details | Diff | Splinter Review 
I'm tired of getting these warnings:
/widget/gonk/libdisplay/BootAnimation.cpp: In function 'void TransformTo565(png_structp, png_row_infop, png_bytep)':

/widget/gonk/libdisplay/BootAnimation.cpp:282:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp: In member function 'void AnimationFrame::ReadPngFrame(int)':

/widget/gonk/libdisplay/BootAnimation.cpp:390:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp: In function 'void* AnimationThread(void*)':

/widget/gonk/libdisplay/BootAnimation.cpp:556:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:588:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:588:73: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:591:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:592:48: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:602:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:614:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/widget/gonk/libdisplay/BootAnimation.cpp:617:139: warning: format '%d' expects argument of type 'int', but argument 5 has type 'suseconds_t {aka long int}' [-Wformat]

/widget/gonk/libdisplay/BootAnimation.cpp:623:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Just want to fix them.
Assignee: nobody → boris.chiou
Status: NEW → ASSIGNED
Attachment #8603280 - Flags: review?(mwu)
Attachment #8603280 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/4dc3b7ec47d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.