Closed
Bug 1162901
Opened 9 years ago
Closed 9 years ago
Fix sign comparison warnings in widget/gonk/BootAnimation.cpp
Categories
(Core Graveyard :: Widget: Gonk, defect)
Core Graveyard
Widget: Gonk
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
Details
Attachments
(1 file)
|
4.80 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
I'm tired of getting these warnings:
/widget/gonk/libdisplay/BootAnimation.cpp: In function 'void TransformTo565(png_structp, png_row_infop, png_bytep)':
/widget/gonk/libdisplay/BootAnimation.cpp:282:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp: In member function 'void AnimationFrame::ReadPngFrame(int)':
/widget/gonk/libdisplay/BootAnimation.cpp:390:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp: In function 'void* AnimationThread(void*)':
/widget/gonk/libdisplay/BootAnimation.cpp:556:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:588:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:588:73: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:591:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:592:48: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:602:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:614:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/widget/gonk/libdisplay/BootAnimation.cpp:617:139: warning: format '%d' expects argument of type 'int', but argument 5 has type 'suseconds_t {aka long int}' [-Wformat]
/widget/gonk/libdisplay/BootAnimation.cpp:623:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Just want to fix them.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → boris.chiou
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8603280 -
Flags: review?(mwu)
| Comment hidden (obsolete) |
|
||
Updated•9 years ago
|
Attachment #8603280 -
Flags: review?(mwu) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ee7e0bbceaf
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dc3b7ec47d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•