1163035 - Counting bookmarks is broken in Library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:
1. Open "Library" (Ctrl+Shift+B)
2. Go to "Bookmarks Toolbar", "Bookmarks Menu" or "Unsorted Bookmarks"
3. Select more than 1 bookmark


Actual results:
Bookmark items aren't counted.


Expected results:
I can see how much items I selected.



Regression window (mozilla-inbound-win32)
Good:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1429822861/

Bad:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1429824241/

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2f2888ca42c2&tochange=2a1ddf08a4b4


Probably caused by:
Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak



[Tracking Requested - why for this release]: Regression

Comment 1

[Marco Bonardo [:mak]]

It still works for folders and separators, for uris we just show the tags field, while we should also show the count.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1

we are now always hiding/showing this programmatically, no need to hide it by default.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fc6a63c30b02

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fc6a63c30b02

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Requesting an uplift to Firefox 40

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8604104 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: bookmarks panel rewrite
[User impact if declined]: selecting multiple items in the Library doesn't show the selection count
[Describe test coverage new/current, TreeHerder]: Nightly, manual testing
[Risks and why]: low risk oneline xul fix
[String/UUID change made/needed]: none

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8604104 [details] [diff] [review]
patch v1

Pretty trivial change. Aurora+

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aab9ca1d2c4a

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Looks fixed.
Thank you very much.