Closed
Bug 1163121
Opened 10 years ago
Closed 9 years ago
Create ReaderModeBarView lazy
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: st3fan, Assigned: sleroux)
References
Details
Attachments
(1 file)
Suggestion to shave off ~ 100ms
BrowserViewController.viewDidLoad() takes about 200 ms. Half of that is the creation of the ReaderModeBarView. We should to create that view lazily when it is needed. Not always at app startup.
|
||
Updated•10 years ago
|
Assignee: nobody → sleroux
tracking-fennec: ? → +
|
Assignee | |
Comment 1•9 years ago
|
||
Instead of setting up the readerModeBar in viewDidLoad for every page, the readerModeBar now only gets initialized when it needs to be shown.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8614062 -
Flags: review?(bnicholson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8614062 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/541
Looks good!
Attachment #8614062 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Merged.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•