Closed Bug 1163135 Opened 8 years ago Closed 8 years ago

Make it safer to start profiler via signal

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(1 file)

Make it safer to start the profiler via signal (v1)
2.12 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
Right now when we start the profiler via a signal, profiler_start is called directly from the signal handler. On other platforms, the signal is normally handled on the Gecko thread so we're more or less okay. On Android, the signal is normally handled on the Java UI thread so we could run into more problems. We should dispatch an event to the main thread to start the profiler.
Asking snorp to review since BenWa is still away.
Attachment #8603527 - Flags: review?(snorp)
Comment on attachment 8603527 [details] [diff] [review]
Make it safer to start the profiler via signal (v1)

Review of attachment 8603527 [details] [diff] [review]:
-----------------------------------------------------------------

We could probably make NS_DispatchToMain() signal safe if it isn't already.
Attachment #8603527 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/4870410b92fa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.