1163160 - release history revision count incorrect in UI

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[hwine]

Attachment: Screen Shot 2015-05-08 at 13.44.56.png

See attached screenshot - highest (current) release is 93, section header claims 100.

Comment 1

[hwine]

Attachment: Screen Shot 2015-05-08 at 13.48.31.png

related, so including - the parent page shows 130 revisions

Comment 2

[[e-mail] (:bhearsum)]

This affects rules and releases, updating summary. I also added some rule history to the sample data, so this bug can now be reproduced with a local docker image.

Comment 3

[Njira]

This is a backend problem. The api returns a default limit of 100 revisions and a default count of 1024.

Comment 4

[Njira]

(In reply to Njira from comment #3)
> This is a backend problem. The api returns a default limit of 100 revisions
> and a default count of 1024.

The default count is actually total_count of the revisions..

Comment 5

[[e-mail] (:bhearsum)]

Unfortunately, I had to back this out because it broke pagination on the non-history views (ie: http://localhost:8080/rules). I found two problems:
1) The pagination controls disappeared.
2) When I managed to get them re-added (by adjusting the ng-show), the items didn't change as I changed pages, probably due to the dropping of the startFrom filter.

If there's a quick fix for it, that would be great. In the longer term, it might be worth looking at separating the history and non-history templates/controllers, as they are diverging a lot now.

Comment 6

[Njira]

Can we have the rules/releases views also paginated server-side..?

Comment 7

[[e-mail] (:bhearsum)]

Thanks for fixing this Njira!