replace "add a new user" with "add a new permission"

NEW
Assigned to

Status

Release Engineering
Balrog: Frontend
P3
normal
2 years ago
2 months ago

People

(Reporter: nhirata, Assigned: Nitin, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][good first bug])

1. go to balrog site
2. sign in through ldap
3. select permissions
4. click on add a new user

Expected: need admin rights or such ( I had no account initially )
Actual: no error message.  I was able to create an account, I tried placing in admin that's when I got an error message.  The permission wasn't granted, the account was created though.
See Also: → bug 1163228
Removing relation to bug 1163228, since that was actually caused by something totally different.

Naoki, can you give me a more detailed STR? I suspect this is a UI/UX issue, not an actual problem.
Flags: needinfo?(nhirata.bugzilla)
See Also: bug 1163228
https://aus4-admin.mozilla.org/permissions

is the permissions page, and I believe it's because I had ldap access w/ group balrog already.  I wasn't able to add a permissions, I was however able to create an account.

It just might be UX/UI bug.
Flags: needinfo?(nhirata.bugzilla)
This really is a UX issue. The Permissions UI thinks of accounts and permissions separately, whereas the backend and database require a user to have a permission to have an "account". I think the best thing to do here is replace the "Add a new User" button with "Add a new Permission", and have that pop a dialog that allows one to enter a username and permission.
Mentor: bhearsum@mozilla.com
Summary: anyone who has access to the ui interface can create an account regardless of not having an account. → replace "add a new user" with "add a new permission"
Whiteboard: [lang=js][good first bug]

Comment 4

9 months ago
Hello Ben,

I  would like to work on this bug. I feel glad if you can assist me in fixing it.

Thank You.

Updated

8 months ago
Assignee: nobody → alessioscarapazzi
Status: NEW → ASSIGNED
Alessio, have you made any progress on this?
Flags: needinfo?(alessioscarapazzi)

Comment 6

8 months ago
:bhearsum Sorry for taking that long :( .. I'll work on this tonight
Flags: needinfo?(alessioscarapazzi)

Comment 7

8 months ago
:bhearsum latest tomorrow night..
(In reply to Alessio from comment #6)
> :bhearsum Sorry for taking that long :( .. I'll work on this tonight

It's OK. I was just making sure you're still planning to look at it :).
(In reply to Ben Hearsum (:bhearsum) from comment #8)
> (In reply to Alessio from comment #6)
> > :bhearsum Sorry for taking that long :( .. I'll work on this tonight
> 
> It's OK. I was just making sure you're still planning to look at it :).

Looks like you're unable to work on this right now. That's no problem, but I'm going to unassign it in case somebody else can have a look before you can.
Assignee: alessioscarapazzi → nobody
Status: ASSIGNED → NEW

Comment 10

7 months ago
Hi Ben,

I would be interested in fixing this bug if it still remains free.

Thanks,
Sam

Comment 11

6 months ago
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #0)
> 1. go to balrog site
> 2. sign in through ldap
> 3. select permissions
> 4. click on add a new user
> 
> Expected: need admin rights or such ( I had no account initially )
> Actual: no error message.  I was able to create an account, I tried placing
> in admin that's when I got an error message.  The permission wasn't granted,
> the account was created though.

Hi Naoki!
Can you give me a brief explanation and the link of the balrog so that i can work on it as my first bug?

Comment 12

5 months ago
Hi Ben! I would like to take this up. Can you please assign it to me and help me get started in this?
Flags: needinfo?(bhearsum)
(In reply to Aman Dwivedi from comment #12)
> Hi Ben! I would like to take this up. Can you please assign it to me and
> help me get started in this?

Absolutely. Once you've got the development environment up and running (see https://github.com/mozilla/balrog/blob/master/README.rst), have a look at http://localhost:8080/permissions and read comment #3 to see what it is we want to do here. You will likely need to change a few views and controllers to fix this, including:
https://github.com/mozilla/balrog/blob/master/ui/app/templates/permissions.html
https://github.com/mozilla/balrog/blob/master/ui/app/templates/permissions_modal.html
https://github.com/mozilla/balrog/blob/master/ui/app/js/controllers/permissions_controller.js
https://github.com/mozilla/balrog/blob/master/ui/app/js/controllers/user_edit_controller.js

I know this may be a lot to take in, so feel free to reach out here or on irc (irc://irc.mozilla.org/#balrog) if you have any questions.
Assignee: nobody → dwivedi.aman96
Flags: needinfo?(bhearsum)

Comment 14

4 months ago
Hi,

I would like to work on this bug if it is not assigned to anyone.
(In reply to Shruti Singh from comment #14)
> Hi,
> 
> I would like to work on this bug if it is not assigned to anyone.

Aman, are you still looking at this? If not, I'd like to reassign it to Shruti.
Flags: needinfo?(dwivedi.aman96)

Updated

4 months ago
Priority: -- → P3

Comment 16

4 months ago
Hi Ben! Sorry for delay. I m facing difficulty in making the dev setup. There are some system issues. If Shruti can follow with it, would be well and good. :)
Flags: needinfo?(dwivedi.aman96)
(In reply to Aman Dwivedi from comment #16)
> Hi Ben! Sorry for delay. I m facing difficulty in making the dev setup.
> There are some system issues. If Shruti can follow with it, would be well
> and good. :)

No worries, sorry to hear that.

Shruti, if you still want to have a look at this, instructions are in comment #13.
Assignee: dwivedi.aman96 → shrutisingh7219

Comment 18

4 months ago
(In reply to Ben Hearsum (:bhearsum) from comment #17)
> (In reply to Aman Dwivedi from comment #16)
> > Hi Ben! Sorry for delay. I m facing difficulty in making the dev setup.
> > There are some system issues. If Shruti can follow with it, would be well
> > and good. :)
> 
> No worries, sorry to hear that.
> 
> Shruti, if you still want to have a look at this, instructions are in
> comment #13.

Thank you :)
Looking forward to fix it.

Comment 19

4 months ago
Hi Ben!
Instead of starting with this, Can I start with good first bugs?

Comment 20

4 months ago
Hi,Ben!

I have issues with running docker on ubuntu 14.04
I got Error- Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
When I enter command "sudo service docker start", It shows a messsage-"start: Job is already running: docker
"
Will you please help me?

Comment 21

4 months ago
(In reply to Shruti Singh from comment #20)
> Hi,Ben!
> 
> I have issues with running docker on ubuntu 14.04
> I got Error- Cannot connect to the Docker daemon at
> unix:///var/run/docker.sock. Is the docker daemon running?
> When I enter command "sudo service docker start", It shows a
> messsage-"start: Job is already running: docker
> "
> Will you please help me?

Shruti, first of all, did you do the post-install step for docker to be able to run it as non-root? You can find the instructions at https://docs.docker.com/engine/installation/linux/linux-postinstall/#/manage-docker-as-a-non-root-user

Second, did you install docker-compose? If not, you need to grab that as well. You can find the install guide at https://docs.docker.com/compose/install/

After you have everything set up you can just run docker-compose up in the balrog folder to get started.
Are you still planning to look at this Shruti?
Flags: needinfo?(shrutisingh7219)

Comment 23

2 months ago
(In reply to Ben Hearsum (:bhearsum) from comment #22)
> Are you still planning to look at this Shruti?
Hi, Ben!

I am facing some issue regarding installation of docker.It would be fine if anyone else wants to take it up. :)
Thank you and sorry for the inconvenience.:)
(In reply to Shruti Singh from comment #23)
> (In reply to Ben Hearsum (:bhearsum) from comment #22)
> > Are you still planning to look at this Shruti?
> Hi, Ben!
> 
> I am facing some issue regarding installation of docker.It would be fine if
> anyone else wants to take it up. :)
> Thank you and sorry for the inconvenience.:)

No worries.
Assignee: shrutisingh7219 → nobody
Flags: needinfo?(shrutisingh7219)
(Assignee)

Comment 25

2 months ago
Hi Ben, I think this needs to be done to. Can I send a PR regarding this bug?
(In reply to Nitin from comment #25)
> Hi Ben, I think this needs to be done to. Can I send a PR regarding this bug?

Yep.
Assignee: nobody → prakash.nitin63
You need to log in before you can comment on or make changes to this bug.