Last Comment Bug 1163200 - replace "add a new user" with "add a new permission"
: replace "add a new user" with "add a new permission"
Status: NEW
[lang=js][good first bug]
:
Product: Release Engineering
Classification: Other
Component: Balrog: Frontend (show other bugs)
: unspecified
: Unspecified Unspecified
P3 normal (vote)
: ---
Assigned To: Shruti Singh
: Ben Hearsum (:bhearsum)
:
Mentors: Ben Hearsum (:bhearsum)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-08 15:08 PDT by Naoki Hirata :nhirata (please use needinfo instead of cc)
Modified: 2017-02-07 04:49 PST (History)
10 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description User image Naoki Hirata :nhirata (please use needinfo instead of cc) 2015-05-08 15:08:54 PDT
1. go to balrog site
2. sign in through ldap
3. select permissions
4. click on add a new user

Expected: need admin rights or such ( I had no account initially )
Actual: no error message.  I was able to create an account, I tried placing in admin that's when I got an error message.  The permission wasn't granted, the account was created though.
Comment 1 User image Ben Hearsum (:bhearsum) 2015-05-11 05:09:00 PDT
Removing relation to bug 1163228, since that was actually caused by something totally different.

Naoki, can you give me a more detailed STR? I suspect this is a UI/UX issue, not an actual problem.
Comment 2 User image Naoki Hirata :nhirata (please use needinfo instead of cc) 2015-05-13 12:29:33 PDT
https://aus4-admin.mozilla.org/permissions

is the permissions page, and I believe it's because I had ldap access w/ group balrog already.  I wasn't able to add a permissions, I was however able to create an account.

It just might be UX/UI bug.
Comment 3 User image Ben Hearsum (:bhearsum) 2016-08-29 11:11:33 PDT
This really is a UX issue. The Permissions UI thinks of accounts and permissions separately, whereas the backend and database require a user to have a permission to have an "account". I think the best thing to do here is replace the "Add a new User" button with "Add a new Permission", and have that pop a dialog that allows one to enter a username and permission.
Comment 4 User image Wasim Thabraze 2016-08-31 02:30:34 PDT
Hello Ben,

I  would like to work on this bug. I feel glad if you can assist me in fixing it.

Thank You.
Comment 5 User image Ben Hearsum (:bhearsum) 2016-10-11 07:53:50 PDT
Alessio, have you made any progress on this?
Comment 6 User image Alessio 2016-10-11 08:18:49 PDT
:bhearsum Sorry for taking that long :( .. I'll work on this tonight
Comment 7 User image Alessio 2016-10-11 08:24:21 PDT
:bhearsum latest tomorrow night..
Comment 8 User image Ben Hearsum (:bhearsum) 2016-10-11 08:32:42 PDT
(In reply to Alessio from comment #6)
> :bhearsum Sorry for taking that long :( .. I'll work on this tonight

It's OK. I was just making sure you're still planning to look at it :).
Comment 9 User image Ben Hearsum (:bhearsum) 2016-10-24 08:30:32 PDT
(In reply to Ben Hearsum (:bhearsum) from comment #8)
> (In reply to Alessio from comment #6)
> > :bhearsum Sorry for taking that long :( .. I'll work on this tonight
> 
> It's OK. I was just making sure you're still planning to look at it :).

Looks like you're unable to work on this right now. That's no problem, but I'm going to unassign it in case somebody else can have a look before you can.
Comment 10 User image Sam Clusker 2016-11-07 04:43:37 PST
Hi Ben,

I would be interested in fixing this bug if it still remains free.

Thanks,
Sam
Comment 11 User image Owais Kazi 2016-12-04 03:00:09 PST
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #0)
> 1. go to balrog site
> 2. sign in through ldap
> 3. select permissions
> 4. click on add a new user
> 
> Expected: need admin rights or such ( I had no account initially )
> Actual: no error message.  I was able to create an account, I tried placing
> in admin that's when I got an error message.  The permission wasn't granted,
> the account was created though.

Hi Naoki!
Can you give me a brief explanation and the link of the balrog so that i can work on it as my first bug?
Comment 12 User image Aman Dwivedi 2017-01-07 10:56:49 PST
Hi Ben! I would like to take this up. Can you please assign it to me and help me get started in this?
Comment 13 User image Ben Hearsum (:bhearsum) 2017-01-09 05:58:47 PST
(In reply to Aman Dwivedi from comment #12)
> Hi Ben! I would like to take this up. Can you please assign it to me and
> help me get started in this?

Absolutely. Once you've got the development environment up and running (see https://github.com/mozilla/balrog/blob/master/README.rst), have a look at http://localhost:8080/permissions and read comment #3 to see what it is we want to do here. You will likely need to change a few views and controllers to fix this, including:
https://github.com/mozilla/balrog/blob/master/ui/app/templates/permissions.html
https://github.com/mozilla/balrog/blob/master/ui/app/templates/permissions_modal.html
https://github.com/mozilla/balrog/blob/master/ui/app/js/controllers/permissions_controller.js
https://github.com/mozilla/balrog/blob/master/ui/app/js/controllers/user_edit_controller.js

I know this may be a lot to take in, so feel free to reach out here or on irc (irc://irc.mozilla.org/#balrog) if you have any questions.
Comment 14 User image Shruti Singh 2017-01-21 06:00:34 PST
Hi,

I would like to work on this bug if it is not assigned to anyone.
Comment 15 User image Ben Hearsum (:bhearsum) 2017-01-23 10:29:25 PST
(In reply to Shruti Singh from comment #14)
> Hi,
> 
> I would like to work on this bug if it is not assigned to anyone.

Aman, are you still looking at this? If not, I'd like to reassign it to Shruti.
Comment 16 User image Aman Dwivedi 2017-01-23 22:45:06 PST
Hi Ben! Sorry for delay. I m facing difficulty in making the dev setup. There are some system issues. If Shruti can follow with it, would be well and good. :)
Comment 17 User image Ben Hearsum (:bhearsum) 2017-01-24 06:03:26 PST
(In reply to Aman Dwivedi from comment #16)
> Hi Ben! Sorry for delay. I m facing difficulty in making the dev setup.
> There are some system issues. If Shruti can follow with it, would be well
> and good. :)

No worries, sorry to hear that.

Shruti, if you still want to have a look at this, instructions are in comment #13.
Comment 18 User image Shruti Singh 2017-01-24 06:36:49 PST
(In reply to Ben Hearsum (:bhearsum) from comment #17)
> (In reply to Aman Dwivedi from comment #16)
> > Hi Ben! Sorry for delay. I m facing difficulty in making the dev setup.
> > There are some system issues. If Shruti can follow with it, would be well
> > and good. :)
> 
> No worries, sorry to hear that.
> 
> Shruti, if you still want to have a look at this, instructions are in
> comment #13.

Thank you :)
Looking forward to fix it.
Comment 19 User image Shruti Singh 2017-01-26 08:29:35 PST
Hi Ben!
Instead of starting with this, Can I start with good first bugs?
Comment 20 User image Shruti Singh 2017-01-27 10:11:45 PST
Hi,Ben!

I have issues with running docker on ubuntu 14.04
I got Error- Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
When I enter command "sudo service docker start", It shows a messsage-"start: Job is already running: docker
"
Will you please help me?
Comment 21 User image Serban Constantin 2017-02-07 04:49:33 PST
(In reply to Shruti Singh from comment #20)
> Hi,Ben!
> 
> I have issues with running docker on ubuntu 14.04
> I got Error- Cannot connect to the Docker daemon at
> unix:///var/run/docker.sock. Is the docker daemon running?
> When I enter command "sudo service docker start", It shows a
> messsage-"start: Job is already running: docker
> "
> Will you please help me?

Shruti, first of all, did you do the post-install step for docker to be able to run it as non-root? You can find the instructions at https://docs.docker.com/engine/installation/linux/linux-postinstall/#/manage-docker-as-a-non-root-user

Second, did you install docker-compose? If not, you need to grab that as well. You can find the install guide at https://docs.docker.com/compose/install/

After you have everything set up you can just run docker-compose up in the balrog folder to get started.

Note You need to log in before you can comment on or make changes to this bug.