1163211 - Remove windowSoftInputMode comment in AndroidManifest

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The windowSoftInputMode override was removed in bug 1137483 so we should remove the associated comment [1].

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AndroidManifest.xml.in?rev=df64a65ca1bd#108

Comment 1

[Aaron Raimist [:aaronraimist]]

Attachment: bug1163211_removecomment.diff

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9614501321ab

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8604984 [details] [diff] [review]
bug1163211_removecomment.diff

Review of attachment 8604984 [details] [diff] [review]:
-----------------------------------------------------------------

Hey, Aaron - thanks for the patch!

Unfortunately, we need to wait for bug 1137483 to land (see "Depends on:") before we can land this.

I made a push to our try test servers (see above).

Normally, when it went green, you can add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

I'll NI myself so we land this once bug 1137483 lands.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

If you're looking for a followup, perhaps bug 1116349 or bug 1138560?

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/da2104421b94

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Thanks, Aaron!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da2104421b94