Closed
Bug 1163256
Opened 9 years ago
Closed 9 years ago
Intermittent browser_formdata.js | This test exceeded the timeout threshold. It should be rewritten or split up.
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox39 | --- | unaffected |
firefox40 | --- | fixed |
firefox41 | --- | fixed |
firefox-esr31 | --- | unaffected |
firefox-esr38 | --- | unaffected |
People
(Reporter: KWierso, Assigned: ttaubert)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
7.25 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
12:04:31 INFO - 1584 INFO Leaving test test_formdata 12:04:31 INFO - 1585 INFO Entering test test_url_check 12:04:31 INFO - 1586 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | form data restored 12:04:31 INFO - 1587 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | form data not restored 12:04:31 INFO - 1588 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | form data not restored 12:04:31 INFO - 1589 INFO Leaving test test_url_check 12:04:31 INFO - 1590 INFO Entering test test_nested 12:04:31 INFO - 1591 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | formdata for iframe stored correctly 12:04:31 INFO - 1592 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | formdata for iframe restored correctly 12:04:31 INFO - 1593 INFO Leaving test test_nested 12:04:31 INFO - 1594 INFO Entering test test_design_mode 12:04:31 INFO - 1595 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | editable document has been restored correctly 12:04:31 INFO - 1596 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | editable document has been restored correctly 12:04:31 INFO - 1597 INFO Leaving test test_design_mode 12:04:31 INFO - 1598 INFO Entering test test_ccNumbers 12:04:31 INFO - 1599 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1600 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1601 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1602 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1603 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1604 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1605 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1606 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1607 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1608 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1609 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1610 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1611 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1612 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1613 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1614 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1615 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1616 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1617 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1618 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | valid CC numbers are not collected 12:04:31 INFO - 1619 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1620 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1621 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1622 INFO Longer timeout required, waiting longer... Remaining timeouts: 1 12:04:31 INFO - 1623 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1624 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1625 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1626 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1627 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1628 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1629 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1630 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1631 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1632 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1633 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1634 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1635 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1636 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1637 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1638 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1639 INFO TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | numbers that are not valid CC numbers are still collected 12:04:31 INFO - 1640 INFO Leaving test test_ccNumbers 12:04:31 INFO - 1641 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_formdata.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - expected PASS 12:04:31 INFO - MEMORY STAT vsize after test: 899850240 12:04:31 INFO - MEMORY STAT residentFast after test: 330014720 12:04:31 INFO - MEMORY STAT heapAllocated after test: 90205796 12:04:31 INFO - 1642 INFO TEST-OK | browser/components/sessionstore/test/browser_formdata.js | took 92461ms 12:04:31 INFO - ++DOCSHELL 0x894d8c00 == 34 [pid = 4659] [id = 842] 12:04:31 INFO - ++DOMWINDOW == 149 (0x894d9000) [pid = 4659] [serial = 2508] [outer = (nil)] 12:04:31 INFO - ++DOMWINDOW == 150 (0x896a7400) [pid = 4659] [serial = 2509] [outer = 0x894d9000] 12:04:31 INFO - [4659] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-in-lx-d-00000000000000000000/build/src/netwerk/base/nsSimpleURI.cpp, line 264 12:04:31 INFO - [4659] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file /builds/slave/m-in-lx-d-00000000000000000000/build/src/docshell/base/nsDocShell.cpp, line 4577 12:04:31 INFO - 1643 INFO TEST-START | browser/components/sessionstore/test/browser_formdata_format.js
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 41•9 years ago
|
||
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8608003 -
Flags: review?(gijskruitbosch+bugs)
Comment 42•9 years ago
|
||
Comment on attachment 8608003 [details] [diff] [review] 0001-Bug-1163256-Fix-intermittent-browser_formdata.js-tim.patch Review of attachment 8608003 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/sessionstore/test/browser.ini @@ +79,5 @@ > [browser_dynamic_frames.js] > [browser_form_restore_events.js] > [browser_formdata.js] > skip-if = buildapp == 'mulet' > +[browser_formdata_cc.js] Should this be skipped on mulet as well? Do we still care about mulet? ::: browser/components/sessionstore/test/browser_formdata_cc.js @@ +76,5 @@ > + input.value = formValue; > + > + let event = input.ownerDocument.createEvent("UIEvents"); > + event.initUIEvent("input", true, true, input.ownerDocument.defaultView, 0); > + input.dispatchEvent(event); Instead of these 4 lines, please use input.setUserInput(formValue) which should fire all the requisite events for you, AIUI.
Attachment #8608003 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 45•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #42) > > [browser_formdata.js] > > skip-if = buildapp == 'mulet' > > +[browser_formdata_cc.js] > > Should this be skipped on mulet as well? Do we still care about mulet? I don't know why it was skipped or if the whole file fails or just a subset of tests. I thought we'd just see how it goes and could quickly disable it too. > ::: browser/components/sessionstore/test/browser_formdata_cc.js > @@ +76,5 @@ > > + input.value = formValue; > > + > > + let event = input.ownerDocument.createEvent("UIEvents"); > > + event.initUIEvent("input", true, true, input.ownerDocument.defaultView, 0); > > + input.dispatchEvent(event); > > Instead of these 4 lines, please use input.setUserInput(formValue) which > should fire all the requisite events for you, AIUI. Oh wow, didn't know that's a thing :) Thanks!
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 49•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba7bd9ee0af0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
status-firefox39:
--- → unaffected
status-firefox40:
--- → affected
status-firefox-esr31:
--- → unaffected
status-firefox-esr38:
--- → unaffected
Comment 50•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d35e1676457b
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•