1163274 - Add indices for history tables

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Richard Newman [:rnewman]]

We currently have none at all. That'll very rapidly bite us. I intend to fix this as part of, or immediately after, the schema changes in Bug 1163273.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

There's one commit near the end of this PR.

I added only two explicit indices. All of the UNIQUE and PRIMARY KEY columns get an index for free. So I added two:

* An index on should_upload, because otherwise that'll be a table scan for a very small set. Thinking about this, I should make this a partial index on should_upload = 1.

* A compound index on visits.{siteID,date}, because we're always doing a join and datewise comparisons in the same query.

Comment 2

[Richard Newman [:rnewman]]

I made the index partial and rebased.

Comment 3

[Richard Newman [:rnewman]]

Reviewed in GH. c68aac4