Closed
Bug 1163290
Opened 10 years ago
Closed 9 years ago
CSS coverage unused rules column overlaps the optimizable pages column
Categories
(DevTools :: Style Editor, defect, P3)
DevTools
Style Editor
Tracking
(firefox50 verified)
VERIFIED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox50 | --- | verified |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file, 1 obsolete file)
3.31 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Blocks: enable-csscoverage
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8770914 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8770914 -
Attachment is obsolete: true
Attachment #8770914 -
Flags: review?(bgrinstead)
Attachment #8770918 -
Flags: review?(bgrinstead)
Comment 4•9 years ago
|
||
Comment on attachment 8770918 [details] [diff] [review]
Patch
Forwarding review. Gabe, for more context see the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1016288
Attachment #8770918 -
Flags: review?(bgrinstead) → review?(gl)
Comment 5•9 years ago
|
||
Comment on attachment 8770918 [details] [diff] [review]
Patch
Review of attachment 8770918 [details] [diff] [review]:
-----------------------------------------------------------------
I would like to see the 2 styleeditor.css merged as well, but perhaps in a separate bug.
Attachment #8770918 -
Flags: review?(gl) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
has problems to apply:
patching file devtools/client/themes/styleeditor.css
Hunk #1 FAILED at 203
1 out of 4 hunks FAILED -- saving rejects to file devtools/client/themes/styleeditor.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh csscoverage-style-tweaks.patch
Flags: needinfo?(ntim.bugs)
Keywords: checkin-needed
Assignee | ||
Comment 7•9 years ago
|
||
Will rebase and land myself later today.
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/7ba94e0c5daa
Fix up CSS coverage layout and make its text selectable. r=gl a=kwierso CLOSED TREE
Comment 9•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 10•8 years ago
|
||
I have reproduced this on lightly according to (2015-05-09 )
fixing bug is verified on Latest Developer Edition-- Build ID:( 20160826004001 ), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0
Tested OS-- Windows10 32bit
QA Whiteboard: [testday-20160826]
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•