Closed Bug 1163290 Opened 9 years ago Closed 8 years ago

CSS coverage unused rules column overlaps the optimizable pages column

Categories

(DevTools :: Style Editor, defect, P3)

Product:
DevTools
Component:
Style Editor
Type:
defect

Tracking

(firefox50 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
firefox50 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
3.31 KB, patch
gl
: review+
Details | Diff | Splinter Review 
      No description provided.
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P3
Blocks: enable-csscoverage
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) — — Splinter Review 

        Attachment #8770914 -
        Flags: review?(bgrinstead)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  

        Attachment #8770914 -
        Attachment is obsolete: true

        Attachment #8770914 -
        Flags: review?(bgrinstead)

        Attachment #8770918 -
        Flags: review?(bgrinstead)

    
    

    
  
Comment on attachment 8770918 [details] [diff] [review]
Patch

Forwarding review.  Gabe, for more context see the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1016288

        Attachment #8770918 -
        Flags: review?(bgrinstead) → review?(gl)

    
    

    
  
Comment on attachment 8770918 [details] [diff] [review]
Patch

Review of attachment 8770918 [details] [diff] [review]:
-----------------------------------------------------------------

I would like to see the 2 styleeditor.css merged as well, but perhaps in a separate bug.

        Attachment #8770918 -
        Flags: review?(gl) → review+

    
  
Keywords: checkin-needed

    
    

    
  
has problems to apply:

patching file devtools/client/themes/styleeditor.css
Hunk #1 FAILED at 203
1 out of 4 hunks FAILED -- saving rejects to file devtools/client/themes/styleeditor.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh csscoverage-style-tweaks.patch
Flags: needinfo?(ntim.bugs)
Keywords: checkin-needed

    
    

    
  
Will rebase and land myself later today.
Flags: needinfo?(ntim.bugs)

    
    

    
  
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/7ba94e0c5daa
Fix up CSS coverage layout and make its text selectable. r=gl a=kwierso CLOSED TREE

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7ba94e0c5daa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox50:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

    
    

    
  
I have reproduced this on lightly according to (2015-05-09 )

fixing bug is verified on Latest Developer Edition-- Build ID:( 20160826004001 ), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0


Tested OS-- Windows10 32bit
QA Whiteboard: [testday-20160826]

    
  
Status: RESOLVED → VERIFIED

          status-firefox50:
          fixed → verified

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: