1163311 - test_backspace_delete.xul fails if IME requests to query content at selection change

Status: NEW

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch to reproduce this bug on any environments

I hit this bug when I work on bug 1130935.

On some platforms, IME needs selection change notification (e.g., when moving caret even if there is no composition). Then, IME may try to query our editor content synchronously.

With such case, layout/generic/test/test_backspace_delete.xul fails.

> 2499 INFO TEST-UNEXPECTED-FAIL | layout/generic/test/test_backspace_delete.xul | Delete broken in "اهلاhello", offset 4 with deleteImmediately=false - got اهلاhello, expected اهلاello
> 2503 INFO TEST-UNEXPECTED-FAIL | layout/generic/test/test_backspace_delete.xul | Backspace broken in "اهلاhello", offset 4 with deleteImmediately=false - got اهلاhello, expected اهلاello 

The failure part must be:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_backspace_delete.xul?mark=242-243#231

In e10s mode, puppet widget tries to query selection range at every selection change. So, this must be a cause of failure of this test in e10s mode.

smontagu: Do you have any idea for this?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

smontagu:

If you're busy and you cannot investigate this for now, I'll disable the test or make the checks todo_is since the orange does detect existing bug or is just a bug of the test. Anyway, fixing bug 1130935 is more important for now.

Comment 2

[Simon Montagu :smontagu]

Disabling the test in e10s mode is fine.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Simon Montagu :smontagu from comment #2)
> Disabling the test in e10s mode is fine.

Not only in e10s mode. The orange becomes permanent even in non-e10s mode if we land the patches of bug 1130935 or when I run the test on my environment even without the patches. That means that the orange case doesn't work as expected with some IME or keyboard layouts already.

Comment 4

[Simon Montagu :smontagu]

OK, so I agree that bug 1130935 is more important. Please mark the test as failing with a reference to this bug, and I'll look for a fix.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.