Closed Bug 1163331 Opened 5 years ago Closed 5 years ago

Update /mailnews/ for PLDHashTable API changes

Categories

(MailNews Core :: Backend, defect)

defect
Not set
blocker

Tracking

(thunderbird40 unaffected, thunderbird41 fixed, seamonkey2.35 unaffected, seamonkey2.36 unaffected, seamonkey2.37 fixed)

RESOLVED FIXED
Thunderbird 41.0
Tracking Status
thunderbird40 --- unaffected
thunderbird41 --- fixed
seamonkey2.35 --- unaffected
seamonkey2.36 --- unaffected
seamonkey2.37 --- fixed

People

(Reporter: philip.chee, Assigned: njn)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1161377 - PLDHashTable: Add and use an initializing constructor and destructor
https://hg.mozilla.org/mozilla-central/rev/2eae1608bcfa
Bug 1161377 removed PL_NewDHashTable() and PL_DHashTableDestroy()
Replace with multi-arg constructor
Attachment #8603754 - Flags: review?(rkent)
Sorry about this. I was going to write a patch on Friday for c-c but a fresh checkout didn't compile and then I got distracted and then Friday was over and it was the weekend.
Comment on attachment 8603754 [details] [diff] [review]
Patch v1.0 Proposed fix [Checked in: Comment 4]

I did not try to compile this with the other ongoing breakage, but the changes are pretty straightforward. r=me
Attachment #8603754 - Flags: review?(rkent) → review+
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
Comment on attachment 8603754 [details] [diff] [review]
Patch v1.0 Proposed fix [Checked in: Comment 4]

https://hg.mozilla.org/comm-central/rev/95616afdd719
Attachment #8603754 - Attachment description: Patch v1.0 Proposed fix → Patch v1.0 Proposed fix [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Bug 1161377's patches were backed out, so this will have to backed out at some point too. Sorry :(
Backed out https://hg.mozilla.org/comm-central/rev/fcbd8eb059be due to backout of m-c bug.

Reopening since we'll probably want to reland later.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Duplicate of this bug: 1165665
The new PLDHashTable API changes are in bug 1170416.
Depends on: 1170416
No longer depends on: 1161377
Summary: Remove PL_NewDHashTable() and PL_DHashTableDestroy() from /mailnews/ → Update /mailnews/ for PLDHashTable API changes
Assignee: philip.chee → n.nethercote
Status: REOPENED → ASSIGNED
Attachment #8603754 - Attachment is obsolete: true
Duplicate of this bug: 1171080
Comment on attachment 8614513 [details] [diff] [review]
Update /mailnews/ for PLDHashTable API changes

https://hg.mozilla.org/comm-central/rev/b3a333547c76

I pushed this since we are busted without it.
Attachment #8614513 - Flags: review?(rkent) → review+
Severity: normal → blocker
Target Milestone: Thunderbird 40.0 → Thunderbird 41.0
Version: Trunk → 41
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 1129692
You need to log in before you can comment on or make changes to this bug.