1163349 - "View Pocket List" menuitem not working

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

(Thanks for the accidental early bug submission, Bugzilla.)

The "View Pocket List" menuitem in the bookmarks menu and bookmarks button menupanel are not working. Clicking them does nothing. Console shows:

JavaScript error: resource:///modules/Pocket.jsm, line 18: ReferenceError: Services is not defined

Fix is trivial.

Comment 2

[Justin Dolske [:Dolske]]

[This bug is a textbook case of what happens when features are rushed. Bug 1161654 broke the context menu, that was fixed in bug 1162735 but in doing so it introduced this bug. :(]

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 8603767 [details] [diff] [review]
Patch v.1

[Triage Comment]

Required for Pocket / 38.0.5 release.

Comment 4

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/e97254ce4e95

Comment 5

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4561deebcba7
https://hg.mozilla.org/releases/mozilla-release/rev/83c0c74947a3

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified using Firefox 38.0.5 beta 1 and latest Dev Edition 2015-05-11 that "View Pocket List" menuitem from Bookmarks menu and toolbar points to Pocket List.
Environments used: Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5.

Comment 7

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Removing qe-verify flag as verification on Beta 38.0.5 and Aurora 39 should suffice.