Closed Bug 1163349 Opened 6 years ago Closed 6 years ago

"View Pocket List" menuitem not working

Categories

(Firefox :: Pocket, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox38.0.5 --- verified
firefox39 --- verified
firefox40 --- fixed

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

No description provided.
Attached patch Patch v.1Splinter Review
(Thanks for the accidental early bug submission, Bugzilla.)

The "View Pocket List" menuitem in the bookmarks menu and bookmarks button menupanel are not working. Clicking them does nothing. Console shows:

JavaScript error: resource:///modules/Pocket.jsm, line 18: ReferenceError: Services is not defined

Fix is trivial.
Assignee: nobody → dolske
Attachment #8603767 - Flags: review?(jaws)
[This bug is a textbook case of what happens when features are rushed. Bug 1161654 broke the context menu, that was fixed in bug 1162735 but in doing so it introduced this bug. :(]
Blocks: 1162735
Priority: -- → P1
Attachment #8603767 - Flags: review?(jaws) → review+
Comment on attachment 8603767 [details] [diff] [review]
Patch v.1

[Triage Comment]

Required for Pocket / 38.0.5 release.
Attachment #8603767 - Flags: approval-mozilla-release+
Attachment #8603767 - Flags: approval-mozilla-aurora+
Iteration: --- → 40.3 - 11 May
Flags: qe-verify?
Flags: firefox-backlog+
Flags: qe-verify? → qe-verify+
QA Contact: andrei.vaida
Verified using Firefox 38.0.5 beta 1 and latest Dev Edition 2015-05-11 that "View Pocket List" menuitem from Bookmarks menu and toolbar points to Pocket List.
Environments used: Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5.
Removing qe-verify flag as verification on Beta 38.0.5 and Aurora 39 should suffice.
Flags: qe-verify+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.