Closed Bug 1163394 Opened 5 years ago Closed 5 years ago

[System] Convert templates to use tagged.js

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8603826 [details] [review]
[gaia] KevinGrandon:bug_1163394_system_taggedjs_templates > mozilla-b2g:master

Alive - can you take a look when you get a chance? Right now we have two duplicated ways of templating content in the system app, and we should move forward to migrating things to tagged.js. Thanks!
Attachment #8603826 - Flags: review?(alive)
Comment on attachment 8603826 [details] [review]
[gaia] KevinGrandon:bug_1163394_system_taggedjs_templates > mozilla-b2g:master

Cool, thanks!
Attachment #8603826 - Flags: review?(alive) → review+
Thanks Alive, I hope this does not interfere with your bootstrap patch. Let me know if it does or if you need help rebasing.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
I know it's been a long time, but I noticed we still try to load the shared/js/template.js lib in [1]. Maybe you'd like to fix this :)

[1] https://github.com/mozilla-b2g/gaia/blob/578c972114e6ad0b3284515b0d29c9d72073961a/apps/system/js/app_install_manager.js#L100
(In reply to Julien Wajsberg [:julienw] from comment #6)
> I know it's been a long time, but I noticed we still try to load the
> shared/js/template.js lib in [1]. Maybe you'd like to fix this :)
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/
> 578c972114e6ad0b3284515b0d29c9d72073961a/apps/system/js/app_install_manager.
> js#L100

Nice find, I'll file a bug for this.
Depends on: 1232713
You need to log in before you can comment on or make changes to this bug.