1163394 - [System] Convert templates to use tagged.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1163394_system_taggedjs_templates > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8603826 [details] [review]
[gaia] KevinGrandon:bug_1163394_system_taggedjs_templates > mozilla-b2g:master

Alive - can you take a look when you get a chance? Right now we have two duplicated ways of templating content in the system app, and we should move forward to migrating things to tagged.js. Thanks!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8603826 [details] [review]
[gaia] KevinGrandon:bug_1163394_system_taggedjs_templates > mozilla-b2g:master

Cool, thanks!

Comment 4

[Kevin Grandon :kgrandon]

Thanks Alive, I hope this does not interfere with your bootstrap patch. Let me know if it does or if you need help rebasing.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/33760794f41a50c6b523d35c774e0fdc371bd8fc

Comment 6

[Julien Wajsberg [:julienw]]

I know it's been a long time, but I noticed we still try to load the shared/js/template.js lib in [1]. Maybe you'd like to fix this :)

[1] https://github.com/mozilla-b2g/gaia/blob/578c972114e6ad0b3284515b0d29c9d72073961a/apps/system/js/app_install_manager.js#L100

Comment 7

[Kevin Grandon :kgrandon]

(In reply to Julien Wajsberg [:julienw] from comment #6)
> I know it's been a long time, but I noticed we still try to load the
> shared/js/template.js lib in [1]. Maybe you'd like to fix this :)
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/
> 578c972114e6ad0b3284515b0d29c9d72073961a/apps/system/js/app_install_manager.
> js#L100

Nice find, I'll file a bug for this.