Closed Bug 1163453 Opened 9 years ago Closed 9 years ago

Rename Interval::Union

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

Rename Interval<T>::Union into ::Span
1.60 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
The naming of Interval::Union is confusing in particular when the two intervals are disjoints.

It should be renamed.
MediaByteRange which provides a similar API, use Extents.
Blocks: 1163445
Rename Interval::Union into Interval::Span. I've considered all the other options, in particual Extents but an extent has a very precise definition which doesn't appear to cover what we want to do here. BTW, the MediaByteRange::Extents implementation is buggy (it's not commutative) but that's for another bug
Attachment #8604469 - Flags: review?(matt.woodrow)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attachment #8604469 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/19303e91c5d9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: