1163465 - Remove HACK_first_released_version

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

For 38.0.5b1 we had this partial list:  
  38.0build3,38.0build2,38.0b9build1
(not originally, but we'll ignore that here)

And we hit this error:
ERROR : Requested file, firefox-38.0.complete.mar, does not exist on http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/38.0-candidates/build2/update/win64/en-US/firefox-38.0.complete.mar Check again, or use -b to bypass

Which is quite right, we had no intention of shipping win64 at 38.0 and didn't build it. The problem is that we didn't skip the check based on HACK_first_released_version from the release config.

The relevant code is http://hg.mozilla.org/build/tools/file/2b15778a8b1d/buildbot-helpers/release_sanity.py#l251
where we are comparing 38.0 < 37.0b2 and get False, so don't skip the file existence check. We didn't hit this for 38.0b1 because LooseVersion has 37.0 < 37.0b2 (um, ok).

Other usage of HACK_first_released_version would also need fixing, eg
http://mxr.mozilla.org/build/source/buildbotcustom/process/release.py#670
mxr.mozilla.org/build/source/tools/scripts/l10n/create-release-repacks.py#338

We might have to read the relevant release config by tag to determine the shipped platforms.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The end result for 38.0.5b1 was dropping the 38.0 partials altogether, so that'll mean slower uptake for that once we ship it. Bug 1163463 is related.

Comment 2

[[e-mail] (:bhearsum)]

This bug talks about release configs, which are dead. I'm going to assume it's no longer a problem.

Comment 3

[Rail Aliiev [:rail]]

there are some references in the code, I'll remove it.

Comment 4

[Rail Aliiev [:rail]]

Attachment: Bug 1163465 - Remove HACK_first_released_version

Remove HACK_first_released_version and release_sanity.py which is unused in
release promotion anymore.

Review commit: https://reviewboard.mozilla.org/r/110348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110348/

Comment 5

[Rail Aliiev [:rail]]

Attachment: Bug 1163465 - Remove HACK_first_released_version.

Also remove unused moz_repo_path and undefined enUS_signed_apk_url.

Review commit: https://reviewboard.mozilla.org/r/110352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110352/

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8834391 [details]
Bug 1163465 - Remove HACK_first_released_version

https://reviewboard.mozilla.org/r/110348/#review111660

for some reason I thought fennec used this release sanity logic. can't prove that now so r+

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8834393 [details]
Bug 1163465 - Remove HACK_first_released_version.

https://reviewboard.mozilla.org/r/110352/#review111662

the office feels cleaner now :)

Comment 8

[Rail Aliiev [:rail]]

(In reply to Jordan Lund (:jlund) from comment #6)
> Comment on attachment 8834391 [details]
> Bug 1163465 - Remove HACK_first_released_version.
> 
> https://reviewboard.mozilla.org/r/110348/#review111660
> 
> for some reason I thought fennec used this release sanity logic. can't prove
> that now so r+

Fennec uses the old-release-runner branch.

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8834391 [details]
Bug 1163465 - Remove HACK_first_released_version

https://hg.mozilla.org/build/tools/rev/499cff94a7edecbd1938b3cd57b159f6e1ce59a6

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 8834393 [details]
Bug 1163465 - Remove HACK_first_released_version.

https://hg.mozilla.org/build/buildbotcustom/rev/fc664d42c36f1d0f4c8132031e0b64be19bb75d6

Comment 11

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/fc664d42c36f

Comment 12

[Rail Aliiev [:rail]]

doh, fennec uses relase sanity from default...

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 8834391 [details]
Bug 1163465 - Remove HACK_first_released_version

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/110348/diff/1-2/

Comment 14

[Jordan Lund (:jlund)]

Comment on attachment 8834391 [details]
Bug 1163465 - Remove HACK_first_released_version

https://reviewboard.mozilla.org/r/110348/#review113882

Comment 15

[Rail Aliiev [:rail]]

https://hg.mozilla.org/build/tools/rev/acf45ca949609864729d3b299fec601fd56934e7