Closed Bug 1163465 Opened 11 years ago Closed 9 years ago

Remove HACK_first_released_version

Categories

(Release Engineering :: Release Automation, defect)

Product:
Release Engineering
Component:
Release Automation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: rail)

Details

Attachments

(2 files)

Bug 1163465 - Remove HACK_first_released_version
59 bytes, text/x-review-board-request
jlund
: review+
rail
: checked-in+
Details
Bug 1163465 - Remove HACK_first_released_version.
59 bytes, text/x-review-board-request
jlund
: review+
rail
: checked-in+
Details
For 38.0.5b1 we had this partial list: 38.0build3,38.0build2,38.0b9build1 (not originally, but we'll ignore that here) And we hit this error: ERROR : Requested file, firefox-38.0.complete.mar, does not exist on http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/38.0-candidates/build2/update/win64/en-US/firefox-38.0.complete.mar Check again, or use -b to bypass Which is quite right, we had no intention of shipping win64 at 38.0 and didn't build it. The problem is that we didn't skip the check based on HACK_first_released_version from the release config. The relevant code is http://hg.mozilla.org/build/tools/file/2b15778a8b1d/buildbot-helpers/release_sanity.py#l251 where we are comparing 38.0 < 37.0b2 and get False, so don't skip the file existence check. We didn't hit this for 38.0b1 because LooseVersion has 37.0 < 37.0b2 (um, ok). Other usage of HACK_first_released_version would also need fixing, eg http://mxr.mozilla.org/build/source/buildbotcustom/process/release.py#670 mxr.mozilla.org/build/source/tools/scripts/l10n/create-release-repacks.py#338 We might have to read the relevant release config by tag to determine the shipped platforms.
The end result for 38.0.5b1 was dropping the 38.0 partials altogether, so that'll mean slower uptake for that once we ship it. Bug 1163463 is related.
Summary: HACK_first_released_version doesn't support release builds on beta → Remove HACK_first_released_version
This bug talks about release configs, which are dead. I'm going to assume it's no longer a problem.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
there are some references in the code, I'll remove it.
Assignee: nobody → rail
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment on attachment 8834391 [details] Bug 1163465 - Remove HACK_first_released_version https://reviewboard.mozilla.org/r/110348/#review111660 for some reason I thought fennec used this release sanity logic. can't prove that now so r+
Attachment #8834391 - Flags: review?(jlund) → review+
Comment on attachment 8834393 [details] Bug 1163465 - Remove HACK_first_released_version. https://reviewboard.mozilla.org/r/110352/#review111662 the office feels cleaner now :)
Attachment #8834393 - Flags: review?(jlund) → review+
(In reply to Jordan Lund (:jlund) from comment #6) > Comment on attachment 8834391 [details] > Bug 1163465 - Remove HACK_first_released_version. > > https://reviewboard.mozilla.org/r/110348/#review111660 > > for some reason I thought fennec used this release sanity logic. can't prove > that now so r+ Fennec uses the old-release-runner branch.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
doh, fennec uses relase sanity from default...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8834391 - Flags: review+ → review?(jlund)
Comment on attachment 8834391 [details] Bug 1163465 - Remove HACK_first_released_version https://reviewboard.mozilla.org/r/110348/#review113882
Attachment #8834391 - Flags: review?(jlund) → review+
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: