1163483 - [emulator-l] [emulator-x86-l] reconsider the number of rild enabled

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Emulator, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We enabled 9 rild on emu-kk and emu-x86-kk. We enabled that many because at that time we heard that there could be a 6-sim device requirement. However, since then we don't see that happened.

I'm filing this bug to see if it's worth keeping 9 rild or it makes more sense to maintain just 2 rild for now.

Comment 1

[Edgar Chen [:edgar]]

I don't have strong opinions on how many sim should emulator-kk support. However maintaining just 2 rild maybe could make emulator-kk run faster :p.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Oh yes, I should have said more about why I raised this question ;)
1) apparently performance issue: I noticed even on emu-x86-kk that Callscreen transition is not smooth at all due to the need to check the status of 9 sims ... it implies that there's room for improvement in our gecko code but still wondering what if we simply reduce the unnecessary rild number .
2) still have a dream that emulator could be used more widely on gaia-ui tests. To achieve that, we need to have an emulator configured as our gaia has been aware

Comment 3

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> Oh yes, I should have said more about why I raised this question ;)
> 1) apparently performance issue: I noticed even on emu-x86-kk that
> Callscreen transition is not smooth at all due to the need to check the
> status of 9 sims ... it implies that there's room for improvement in our
> gecko code but still wondering what if we simply reduce the unnecessary rild
> number .
> 2) still have a dream that emulator could be used more widely on gaia-ui
> tests. To achieve that, we need to have an emulator configured as our gaia
> has been aware

Let's do this in emulator-l :)

Comment 4

[Edgar Chen [:edgar]]

Attachment: [device_generic_goldfish:b2g-5.1.0_r1] PR #32, Maintain only 2 rild/rilproxy on emulator-l

Comment 5

[Edgar Chen [:edgar]]

Attachment: [platform_build:b2g-5.1.0_r1] PR#124, Enable only 2 RIL services on emulator-l

Comment 6

[Edgar Chen [:edgar]]

Attachment: [platform_external_qemu:b2g-studio-1.3] PR #155, Setup MAX_GSM_DEVICES from build configuration

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8641484 [details] [review]
[platform_external_qemu:b2g-studio-1.3] PR #155, Setup MAX_GSM_DEVICES from build configuration

This pull request changes to setup MAX_GSM_DEVICES from build configuration, `EMULATOR_MULTI_SIM`. In this way we could support both single-sim (still have dream about use same branch for emulator-ics :p) or multi-sim with different number of sim slot without modifying the code.

Hi Hsinyi, may I have your review? Thank you.

Comment 8

[Edgar Chen [:edgar]]

Comment on attachment 8641007 [details] [review]
[platform_build:b2g-5.1.0_r1] PR#124, Enable only 2 RIL services on emulator-l

Configure EMULATOR_MULTI_SIM to 2 on emulator-l.

Comment 10

[Edgar Chen [:edgar]]

Comment on attachment 8640967 [details] [review]
[device_generic_goldfish:b2g-5.1.0_r1] PR #32, Maintain only 2 rild/rilproxy on emulator-l

Cancel the review request given that we are no longer working on emulator-l. Thank you.