Closed Bug 1163575 Opened 6 years ago Closed 6 years ago

Intermittent error prevents ProductDashboard from working

Categories

(bugzilla.mozilla.org Graveyard :: Extensions: ProductDashboard, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dylan, Assigned: glob)

Details

Attachments

(1 file)

There appears to be a bug in ProductDashboard that causes javascript variable PD to not be defined before use -- possibly a race condition, as even when it fails "PD" is set in the javascript console.

Thanks to @bitfalls for bringing this to our attention.
Assignee: nobody → glob
Attached patch 1163575_1.patchSplinter Review
- move PD initialisation into <head>
Attachment #8604108 - Flags: review?(dylan)
Comment on attachment 8604108 [details] [diff] [review]
1163575_1.patch

Review of attachment 8604108 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Without the patch, I was able to trigger the error 5 out of 6 attempts (starting from a clear cache).
With the patch, I was not able to trigger the error in more than 6 attempts. High confidence that this works.
Attachment #8604108 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   f7515b3..1ad9a82  master -> master
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.