1163630 - Remove “clear all current history” link from Options/Preferences when in Private Browsing mode

Status: NEW

(Firefox :: Private Browsing, defect, P5)

Description

[Gingerbread Man]

It appears the “clear all current history” link isn't supposed to be under Options/Preferences → Privacy / about:preferences#privacy in permanent private browsing mode.
* Bug 480260, comment 7
* Bug 463607, comment 40

As far as I can tell, this is where the regression occurred:
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/privacy.dtd?rev=054195131304#67

Comment 1

[Gingerbread Man]

Ehsan, you seem like the right person to ask for a decision on this.

Comment 2

[(no longer active)]

Hiding these links when about:preferences is loaded in a private window sounds reasonable to me.

Comment 3

[Gingerbread Man]

Attachment: clearallhistory_59.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
20171124100500

It's even worse now. It opens a tab-modal pop-up that's too small for the content and can't be resized.

Comment 4

[Andrew Overholt [:overholt]]

(In reply to Gingerbread Man from comment #3)
> It's even worse now. It opens a tab-modal pop-up that's too small for the
> content and can't be resized.

Did this just change in 59? Do you know when the tab-modal popup arrived?

Comment 5

[Gingerbread Man]

No, it's not new. "clear all current history" started opening a tab-modal dialog in Firefox 52.

Comment 6

[Andrew Overholt [:overholt]]

OK thanks. We track bugs with the regression keyword a bit uniquely so I'm going to mark the recent/upcoming releases as "fix-optional" to get them off our high priority radar.

In the meantime, maybe jdm knows who could perhaps fix this?

Comment 7

[Josh Matthews [:jdm]]

Someone familiar with the preferences UI implementation. I don't know who that is.

Comment 8

[Andrew Overholt [:overholt]]

Justin, do you know who could take this?

Comment 9

[Justin Dolske [:Dolske]]

Sounds like this last worked in Firefox 38? (Current release as of filing date?)

I'd take a fix, but it doesn't feel like a priority.