Closed
Bug 1163693
Opened 10 years ago
Closed 10 years ago
View Source's external editor support fallback is broken
Categories
(Toolkit :: View Source, defect)
Toolkit
View Source
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
[Tracking Requested - why for this release]:
If view_source.editor.external is set to true, but an invalid path is set for view_source.editor.path, fallback code goes back to using the internal view source viewer.
Unfortunately, that code path will be broken by bug 1025146, as openInInternalViewer has been renamed to _openInInternalViewer.
I'm not sure if bug 1025146 made the 40 cutoff, so not sure if this should track that.
Assignee | ||
Comment 1•10 years ago
|
||
/r/8839 - Bug 1163693 - Fix View Source external editor fallback. r=?
Pull down this commit:
hg pull -r 04b420981db1cbbe15d25d6cbfeed4510f413ca7 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606349 -
Flags: review?(jryans)
Attachment #8606349 -
Flags: review?(jryans) → review+
Comment on attachment 8606349 [details]
MozReview Request: bz://1163693/mconley
https://reviewboard.mozilla.org/r/8837/#review7533
Ship It!
Assignee: nobody → mconley
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8606349 -
Attachment is obsolete: true
Attachment #8620268 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•