1163693 - View Source's external editor support fallback is broken

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

If view_source.editor.external is set to true, but an invalid path is set for view_source.editor.path, fallback code goes back to using the internal view source viewer.

Unfortunately, that code path will be broken by bug 1025146, as openInInternalViewer has been renamed to _openInInternalViewer.

I'm not sure if bug 1025146 made the 40 cutoff, so not sure if this should track that.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: bz://1163693/mconley

/r/8839 - Bug 1163693 - Fix View Source external editor fallback. r=?

Pull down this commit:

hg pull -r 04b420981db1cbbe15d25d6cbfeed4510f413ca7 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8606349 [details]
MozReview Request: bz://1163693/mconley

https://reviewboard.mozilla.org/r/8837/#review7533

Ship It!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/32976e27159e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32976e27159e

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1163693 - Fix View Source external editor fallback. r=?