Closed Bug 1163693 Opened 7 years ago Closed 7 years ago
View Source's external editor support fallback is broken
39 bytes, text/x-review-board-request
[Tracking Requested - why for this release]: If view_source.editor.external is set to true, but an invalid path is set for view_source.editor.path, fallback code goes back to using the internal view source viewer. Unfortunately, that code path will be broken by bug 1025146, as openInInternalViewer has been renamed to _openInInternalViewer. I'm not sure if bug 1025146 made the 40 cutoff, so not sure if this should track that.
/r/8839 - Bug 1163693 - Fix View Source external editor fallback. r=? Pull down this commit: hg pull -r 04b420981db1cbbe15d25d6cbfeed4510f413ca7 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606349 - Flags: review?(jryans)
Attachment #8606349 - Flags: review?(jryans) → review+
Comment on attachment 8606349 [details] MozReview Request: bz://1163693/mconley https://reviewboard.mozilla.org/r/8837/#review7533 Ship It!
You need to log in before you can comment on or make changes to this bug.