116378 - Red and Blue components of MNG images swapped on win32

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Atsushi Matsuda]

(Sorry for I misunderstanded and mistaked at #66976.)
I discovered the mistake about the new MNG decoder.
The red ingredient and the blue ingredient are reversed.
RGB(Correct) -> BGR (Incorrect, the present Mozilla)

Comment 1

[tor]

win32 has little imagination regarding byte ordering.  Patch coming up...

Comment 2

[Stuart Ballard]

Don't want to mess with someone else's bug, but might I suggest changing the
summary of this bug to something a little more specific, like "Red and Blue
components of MNG images swapped on win32"? The current summary "New MNG
decoder's bug" could mean anything.

Comment 3

[:deanis74]

I, on the other hand, have no problem messing with someone elses bug (!). 
Resummarizing as suggested.

Comment 4

[tor]

Attachment: BGR byte ordering for win32

Comment 5

[Atsushi Matsuda]

->#2,#3
It seems that the title which I had written before was unclear for you. Thank 
you for changing this.

->#4
Thank you very much.

Comment 6

[tor]

Attachment: fix small problem with previous patch

Note: this is only a temporary change until libmng can handle a BGR8_A8 canvas
target.  I'll submit a patch for that to the libmng author.

Comment 7

[Atsushi Matsuda]

The attachment #62661 [details] [diff] [review] seems not to include it in the source files of 
BuildID:2001122408.
Bug#116378 are not corrected in this BuildID...

Comment 8

[Stuart Parmenter]

Comment on attachment 62661 [details] [diff] [review]
fix small problem with previous patch

r=pavlov

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 62661 [details] [diff] [review]
fix small problem with previous patch

sr=blizzard

Comment 10

[tor]

Checked in.

Comment 11

[:deanis74]

verified by looking at the test url using 2002011103 on Win2k