Closed
Bug 1163871
Opened 10 years ago
Closed 10 years ago
widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]
Categories
(Core Graveyard :: Widget: Gonk, defect)
Core Graveyard
Widget: Gonk
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: dholbert, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.68 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
Build warning when building B2G:
{
widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]
nsresult rv = screen->GetRotation(&rotation);
^
}
This variable is only used in a MOZ_ASSERT statement, so it's debug-only. (hence, it is indeed unused in opt builds)
We should make it DebugOnly<rv>.
|
Reporter | |
Comment 2•10 years ago
|
||
Attachment #8604410 -
Flags: review?(mwu)
|
||
Updated•10 years ago
|
Attachment #8604410 -
Flags: review?(mwu) → review+
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•