Closed Bug 1163871 Opened 4 years ago Closed 4 years ago

widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]

Categories

(Core Graveyard :: Widget: Gonk, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warning when building B2G:
{
widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]
     nsresult rv = screen->GetRotation(&rotation);
              ^
}

This variable is only used in a MOZ_ASSERT statement, so it's debug-only. (hence, it is indeed unused in opt builds)

We should make it DebugOnly<rv>.
er, meant to say DebugOnly<nsresult>
Blocks: buildwarning
Attached patch fix v1Splinter Review
Attachment #8604410 - Flags: review?(mwu)
Attachment #8604410 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/5e043c65eb27
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.