widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]

RESOLVED FIXED in Firefox 41

Status

()

Core
Widget: Gonk
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Build warning when building B2G:
{
widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]
     nsresult rv = screen->GetRotation(&rotation);
              ^
}

This variable is only used in a MOZ_ASSERT statement, so it's debug-only. (hence, it is indeed unused in opt builds)

We should make it DebugOnly<rv>.
(Reporter)

Comment 1

3 years ago
er, meant to say DebugOnly<nsresult>
Blocks: 187528
(Reporter)

Comment 2

3 years ago
Created attachment 8604410 [details] [diff] [review]
fix v1
Attachment #8604410 - Flags: review?(mwu)

Updated

3 years ago
Attachment #8604410 - Flags: review?(mwu) → review+

Comment 3

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/5e043c65eb27
https://hg.mozilla.org/mozilla-central/rev/5e043c65eb27
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.