1163871 - widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning when building B2G:
{
widget/gonk/nsAppShell.cpp:581:14: warning: unused variable 'rv' [-Wunused-variable]
     nsresult rv = screen->GetRotation(&rotation);
              ^
}

This variable is only used in a MOZ_ASSERT statement, so it's debug-only. (hence, it is indeed unused in opt builds)

We should make it DebugOnly<rv>.

Comment 1

[Daniel Holbert [:dholbert]]

er, meant to say DebugOnly<nsresult>

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/5e043c65eb27

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e043c65eb27