1163918 - [Add-On Manager] Rename addon-details-header to reflect new content

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Francesco Lodolo [:flod]]

https://github.com/mozilla-b2g/gaia/commit/3654ec1d7ce1e0a56a34d5c3b06f6a9b33ff79ad#diff-d32b8deaad757f82f46fa1f7d2c9b528

Please do not change strings without changing the ID.

-addon-details-header={{ appName }} Add-on
+addon-details-header={{ appName }}

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] crh0716:1163918 > mozilla-b2g:master

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8604517 [details] [review]
[gaia] crh0716:1163918 > mozilla-b2g:master

Flod, thanks for reminding.

EJ, mind take a look at this patch? Thanks.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8604517 [details] [review]
[gaia] crh0716:1163918 > mozilla-b2g:master

Thanks Arthur, r+.

And by the way, I just filed a bug that we should hint developers when committing if they did change translations under the same locale id. For more information, please check that bug to see details.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ!

Comment 5

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/60771bb0481dc599ccb5abda9687e1e6874536d2