Closed
Bug 1163918
Opened 9 years ago
Closed 9 years ago
[Add-On Manager] Rename addon-details-header to reflect new content
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: arthurcc)
References
Details
Attachments
(1 file)
https://github.com/mozilla-b2g/gaia/commit/3654ec1d7ce1e0a56a34d5c3b06f6a9b33ff79ad#diff-d32b8deaad757f82f46fa1f7d2c9b528 Please do not change strings without changing the ID. -addon-details-header={{ appName }} Add-on +addon-details-header={{ appName }}
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8604517 [details] [review] [gaia] crh0716:1163918 > mozilla-b2g:master Flod, thanks for reminding. EJ, mind take a look at this patch? Thanks.
Attachment #8604517 -
Flags: review?(ejchen)
See Also: → 1164346
Comment on attachment 8604517 [details] [review] [gaia] crh0716:1163918 > mozilla-b2g:master Thanks Arthur, r+. And by the way, I just filed a bug that we should hint developers when committing if they did change translations under the same locale id. For more information, please check that bug to see details.
Attachment #8604517 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → arthur.chen
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•9 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Component: Gaia → Gaia::Settings
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/60771bb0481dc599ccb5abda9687e1e6874536d2
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•