1163974 - [Gtk3] [Dark theme] text in highlighted preferences (about:preferences) is unreadable

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Fedora/Gtk3/Dark theme

Dark theme in Gtk3 means that system uses white text on black background. On the preferences pannel (about:preferences), highlighted texts (on mouse over) are rendered by white color on white background. 

moz-buttonhovertext is used for the highlighted text color. Other colors seems to be hardcoded. I expect we should also hardcode the color for selected item.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: simple fix

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: example

Example of the highlighted text in dark color theme.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8608761 [details] [diff] [review]
simple fix

Can you please look at it? Thanks!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8608761 [details] [diff] [review]
simple fix

Review of attachment 8608761 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, but I'm not sure about this change either, redirecting to Gijs who may have a more solid opinion on it.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8608761 [details] [diff] [review]
simple fix

What is this patch actually trying to do? Just adjust the text color of the labels of hovered radio items? Where is the rule that is setting this to begin with? You're updating the hover color for the entire radio checkmark tree. Is that really necessary?

New rules should be specific to the case in question, and ideally linux-only (use http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/in-content/common.css instead of common.inc.css, unless the problem is the same on Windows with dark themes, or something (seems unlikely, but possible)).

Comment 6

[Martin Stránský [:stransky] (ni? me)]

The origin is here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/checkbox.css#81

81 checkbox:not([disabled="true"]):hover {
82   color: -moz-buttonhovertext;
83   text-shadow: none;
84 }

where -moz-buttonhovertext is white on dark color themes so we need a fixed color for this. This bug affects Linux only.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

What about this one? It uses the same color for normal/hovered text color (like on Windows).

Comment 8

[:Gijs (he/him)]

Comment on attachment 8616859 [details] [diff] [review]
patch

Review of attachment 8616859 [details] [diff] [review]:
-----------------------------------------------------------------

Please make this one rule (ie combine the selectors) and append it after the other radio rules, and add a comment before it explaining why we need to do this.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d94bffd0e4f7

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/46fef2c23d99

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46fef2c23d99