1163999 - Screensharing also stops when user selects 'Stop Sharing' from the camera/microphone permissions drop-down

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Audio/Video, defect, P4)

Description

[Ada [:adalucinet]]

Reproducible on Firefox 38.0.5 beta 1 build 2 (Build ID: 20150511143336)
Affected platforms: Windows 7 x64, Windows 8.1 x86, Mac OS X 10.9.5 and Ubuntu 14.04 x64

Steps to reproduce:
1. Start a conversation on [PC1]
2. Share tabs/windows
3. Copy link and join conversation on another machine [PC2]
4. On [PC1], click the camera icon and select 'Stop sharing' from the dropdown

Expected result:
Sharing is active.

Actual result:
Sharing stops.

Notes:
1. Sharing icon is also dismissed along with the Camera icon, but the 'Hello' and 'Share your screen' icons are still green.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

In case this is confusing:  Stop Sharing (for Camera only, via the icon in the Hello window) causes both camera and screen/etc sharing to stop.  It does correctly reflect this in the icons in the Hello window.  Thus there's no privacy concern here.

Comment 2

[:shell escalante]

just checking - this isn't what we intended, right?  that if you are screen sharing and you "face mute" - your shared screens should keep being shared.

right now when you "face mute" it's "muting" screen sharing too.  seems silly but i wanted to check we didn't do it for a reason before i flag this higher.

Comment 3

[Romain Testard [:RT]]

(In reply to :shell escalante from comment #2)
> just checking - this isn't what we intended, right?  that if you are screen
> sharing and you "face mute" - your shared screens should keep being shared.
> 
> right now when you "face mute" it's "muting" screen sharing too.  seems
> silly but i wanted to check we didn't do it for a reason before i flag this
> higher.

Indeed that was not the intention. We want to be able to face mute without stopping tab/window sharing.

Comment 4

[Mark Banner (:standard8)]

This bug is not about face mute. This is about selecting "Stop Sharing" from the permissions drop-down on the "toolbar" of the Hello conversation window.

There's two parts to this bug:

1) Its a little strange that stop sharing stops both when they are separate prompts. This is probably a UX question, but NI to Florian to see if he knows any history here.

2) As mentioned in Note 1 of comment 0, Hello shows screen sharing as still active. This is a current limitation of WebRTC I believe (Randell, can you confirm this) - it doesn't tell the web page if stop sharing occurs.

Comment 5

[Florian Quèze [:florian]]

(In reply to Mark Banner (:standard8) from comment #4)
> This bug is not about face mute. This is about selecting "Stop Sharing" from
> the permissions drop-down on the "toolbar" of the Hello conversation window.
> 
> There's two parts to this bug:
> 
> 1) Its a little strange that stop sharing stops both when they are separate
> prompts. This is probably a UX question, but NI to Florian to see if he
> knows any history here.

The history is in bug 1050802, see especially comments 15 and 16 there.

Comment 6

[Mark Banner (:standard8)]

Ok, so given comment 5, this seems semi-intention. I think its slightly surprising on the part of the user, but it definitely isn't a loop specific bug.

Therefore moving to webrtc for consideration there.

Comment 7

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 8

[Rares Doghi, Desktop QA]

Tried to reproduce this issue in our latest Release 123.0.1 and Nightly 125 but without success, closing for now but we can reopen if it starts to reoccur.