1164015 - Update test_setup_and_send_receive_imap_email.py imagecompare test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Found that it was not using the in script method to generate necessary screenshots

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1164015 > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8604806 [details] [review]
[gaia] npark-mozilla:1164015 > mozilla-b2g:master

What do you mean with "not using the in script method to generate necessary screenshots"?

Also, why do you remove the tap_star_button and tap_mark_button part? It's not needed anymore?

Comment 3

[No-Jun Park [:njpark]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #2)
> Comment on attachment 8604806 [details] [review]
> [gaia] npark-mozilla:1164015 > mozilla-b2g:master
> 
> What do you mean with "not using the in script method to generate necessary
> screenshots"?
> 
> Also, why do you remove the tap_star_button and tap_mark_button part? It's
> not needed anymore?

Oh, I defined setup_IMAP method inside the script, so I could take shots while in the setup page. But apparently I was calling the setup_IMAP method inside the email class by mistake.

I removed tap_star and tap_mark_button because in the body of the email message, it shows when the message was received, like 'Just Now' or '1 minute ago'.  Depending on the network, some took longer than others, and caused the image compare to fail.  If the email did not receive anything, it is designed to fail anyways, so I decided to remove those two checks at the expensive of checking the icon state, which is not a major feature of the app.

Comment 4

[Martijn Wargers (dead)]

Ok, thanks for the explanation. The test ran fine on my device, btw (although it's a slow test).

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/338f66e6a96491d2f5854b188c6b141ceb690d97