1164090 - BHR reports full file paths

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

The following BHR hang from my about:telemetry page contains a full file path, including the username. This is a privacy risk.

It looks like it might be a bug in how max-length truncation is done.

Gecko-Hang-13
Startup::XRE_Main
nsInputStreamPump::OnInputStreamReady
nsInputStreamPump::OnStateStop
nsHttpChannel::OnStopRequest
nsXMLHttpRequest::OnStopRequest
EventDispatcher::Dispatch
testpilot/modules/remote-experiment-loader.js:32
testpilot/modules/setup.js:742
C:\Users\workvladan\AppData\Roaming\Mozilla\Firefox\Profiles\r4yfabeb.aurora1\TestPilotExperimentFiles\heartbeat-response-tp-ex
testpilot/modules/setup.js:751
testpilot/modules/experiment_data_store.js:27
testpilot/modules/dbutils.js:25
mozStorageConnection::initialize
1 samples, average = 0, sum = 0

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah, it looks like a bug from a combination of using a file directory (not resource:// or chrome://) and using the Windows path separator ('\')

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Check for Windows path separator in BHR file name (v1)

This patch makes us check for Windows path separators too, and if we find it, we use that to derive the path basename.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e94810ac071

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e94810ac071