1164109 - rust code fails to link on macosx because of thread-local storage

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

On MacOS X Yosemite
$ ./mach gtest rust.*
[...]
 0:05.15 ld: targeted OS version does not support use of thread local variables in __ZN6thread7current20hcfeed7bdf861e757etbE for architecture x86_64
 0:05.15 clang: error: linker command failed with exit code 1 (use -v to see invocation)
 0:05.15 make[2]: *** [XUL] Error 1

I swear this worked last week, but maybe not. Still fine on linux64.

Comment 1

[Alex Crichton [:acrichto]]

Was the build targeting OSX 10.6 or prior? Currently Rust uses TLS features that were added in 10.7 and it's known to not work on 10.6 and prior, but 10.7+ should all work just fine (which would make this quite suspicious!).

Comment 2

[Manish Goregaokar [:manishearth]]

(In reply to Alex Crichton [:acrichto] from comment #1)
> Was the build targeting OSX 10.6 or prior? Currently Rust uses TLS features
> that were added in 10.7 and it's known to not work on 10.6 and prior, but
> 10.7+ should all work just fine (which would make this quite suspicious!).

Does this mean that Rust cannot target OSX 10.6 at all? Or does Rust have an issue with 10.6 only if we're using TLS?

:gps, would this be a problem for Firefox integration?

Comment 3

[Alex Crichton [:acrichto]]

Yes this means that the standard library will not target 10.6 right now. Note that this is the only known incompatibility with 10.6, and there are likely ways to work around it, so this is not a fundamental issue, it will just require some work on our side.

Comment 4

[Manish Goregaokar [:manishearth]]

Filed https://github.com/rust-lang/rust/issues/25342 so we don't forget

Comment 5

[Ralph Giles (:rillian)]

Attachment: Incude -lpthread for gtest

Adding an explicit -lpthread resolves the issue.

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8604802 [details] [diff] [review]
Incude -lpthread for gtest

Nevermind.

Comment 7

[Ralph Giles (:rillian)]

Thanks, Alex. I couldn't figure out what was triggering the error message. I guess the linker recognizes the tls-related pthread calls?

In any case, 'ac_add_options --enable-macos-target=10.7' does resolve the issue for me.

Comment 8

[Alex Crichton [:acrichto]]

(In reply to Ralph Giles (:rillian) from comment #7)
> I guess the linker recognizes the tls-related pthread calls?

The current implementation of thread local variables on OSX actually involves a few compiler attributes and avoids pthread entirely, but it looks like the OSX linker is smart enough to know that when you're targeting an older version of OSX that they won't work correctly.

> In any case, 'ac_add_options --enable-macos-target=10.7' does resolve the
> issue for me.

Good to hear!

Comment 9

[Ralph Giles (:rillian)]

Attachment: Require MacOS X 10.7 or later when compiling rust

Add a configure check to prevent building with the unsupported configuration until we can find a better work-around.

Comment 10

[Alex Crichton [:acrichto]]

How much of a hindrance is it that the Rust standard library doesn't work on OSX 10.6 right now? Should we try to prioritize compliance, or is it just a "nice to have"?

Comment 11

[Nathan Froyd [:froydnj]]

At the moment, 10.6 support is "this needs to work to ship Rust code with Firefox".

Comment 12

[Mike Hommey [:glandium]]

Firefox has more users on OSX 10.6 than Linux, iirc, so if you want code to ship in Firefox on OSX, it needs to work on 10.6.

Comment 13

[Alex Crichton [:acrichto]]

Thanks for the clarifications! I'll try to investigate soon how hard it would be to lift this blocker for running on 10.6.

Comment 14

[(not currently active) Ted Mielczarek]

Comment on attachment 8604930 [details] [diff] [review]
Require MacOS X 10.7 or later when compiling rust

Review of attachment 8604930 [details] [diff] [review]:
-----------------------------------------------------------------

If you haven't already, please file a bug on the root issue here so that we can make that block shipping this with Firefox (whether the decision is "drop 10.6 support" or "support 10.6 in Rust").

Comment 15

[Ralph Giles (:rillian)]

Attachment: Require MacOS X 10.7 or later when compiling rust v2

Move the 'checking' message inside the conditional to avoid misleading logs. Carrying forward r=ted.

Comment 16

[Ralph Giles (:rillian)]

Attachment: Require MacOS X 10.7 or later when compiling rust v2

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33e255599053

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33e255599053

Comment 19

[Alfredo Yang (:alfredo)]

I tried to trace the mp4parser rust code but got similar error on m-c (286303:eb25b90a05c1) today.

11:35.33 ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
11:35.33 ld: targeted OS version does not support use of thread local variables in __ZN10sys_common11thread_info14current_thread20h67a0745d7f70577eJAsE for architecture x86_64
11:35.33 clang: error: linker command failed with exit code 1 (use -v to see invocation)
11:35.33 make[5]: *** [XUL] Error 1
11:35.33 make[4]: *** [toolkit/library/target] Error 2
11:35.33 make[4]: *** Waiting for unfinished jobs....
11:35.33 jsapi-tests
11:36.14 ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
11:37.51 ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
11:37.52 make[3]: *** [compile] Error 2
11:37.52 make[2]: *** [default] Error 2
11:37.52 make[1]: *** [realbuild] Error 2
11:37.52 make: *** [build] Error 2
11:37.57 410 compiler warnings present.


My .mozconfig is:

ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --enable-rust


Build environment is:

OS X 10.11.3
rustc 1.6.0 (c30b771ad 2016-01-19)
xcode 7.2.1


Any suggestion?

Comment 20

[Jonathan Chan [:jyc]]

(In reply to Alfredo Yang (:alfredo) from comment #19)
> I tried to trace the mp4parser rust code but got similar error on m-c
> (286303:eb25b90a05c1) today.

Alfredo, did you ever find a resolution? I just ran into the same problem today.

Comment 21

[Alfredo Yang (:alfredo)]

(In reply to Jonathan Chan [:jyc] from comment #20)
> (In reply to Alfredo Yang (:alfredo) from comment #19)
> > I tried to trace the mp4parser rust code but got similar error on m-c
> > (286303:eb25b90a05c1) today.
> 
> Alfredo, did you ever find a resolution? I just ran into the same problem
> today.

No. :(

Comment 22

[Alfredo Yang (:alfredo)]

(In reply to Jonathan Chan [:jyc] from comment #20)
> (In reply to Alfredo Yang (:alfredo) from comment #19)
> > I tried to trace the mp4parser rust code but got similar error on m-c
> > (286303:eb25b90a05c1) today.
> 
> Alfredo, did you ever find a resolution? I just ran into the same problem
> today.

https://bugzilla.mozilla.org/show_bug.cgi?id=1188030#c14

You can try it, it works on my laptop.