1164114 - Handle intent uris without an explicit package set

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In bug 851693 comment 5 (and subsequent comments), it was discussed that there should be a prompt to notify the user that a new page will be opened. While handling the actually intent uri seems fairly straight-forward, displaying the prompt is less so, hence the breakout from bug 851693.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Actually, I never bothered to try it - it *just works* if we don't block on having a specific package set.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1164114 - Open Intent URIs without a specific package set. r?margaret

Bug 1164114 - Open Intent URIs without a specific package set. r?margaret

The Android Activity chooser dialog will appear.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8616974 [details]
MozReview Request: Bug 1164114 - Open Intent URIs without a specific package set. r?margaret

https://reviewboard.mozilla.org/r/10499/#review9311

Nice :)

Comment 4

[Wesley Johnston (:wesj)]

Interesting, even if there's only one app to handle the intent installed? Android still prompts? I would have thought you would need to explicitly use a Choocer intent to always get it... http://developer.android.com/reference/android/content/Intent.html#createChooser%28android.content.Intent,%20java.lang.CharSequence%29

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Wesley Johnston (:wesj) from comment #4)
> Interesting, even if there's only one app to handle the intent installed?

Looking at the comments from bug 851693, it seems I got the UX concerns backward - I was concerned about not showing a dialog when there are multiple applications installed (yeah, I'm not sure how I thought that made sense either).

I filed bug 1173147.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/25f2050820ff

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/25f2050820ff