Closed Bug 1164127 Opened 4 years ago Closed 4 years ago

The hg client should warn if unrecognized users are in the "r?<nick>" string in the commit message

Categories

(MozReview Graveyard :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

Bug 1142251 is going to add the capability to specify reviewers in commit message. It would be nice if the mercurial client warned the user if one of the specified reviewers is not recognized as a valid user.
We're getting bugs filed against reviewer detection and currently have no way to identify what is going wrong. Fixing this might be the best way ahead.
Assignee: nobody → dminor
Priority: P3 → P1
reviewboard: add warning for unrecognized review (bug 1164127); r?gps

This adds a warning to the user if the reviewer specified for review using the
r? syntax is not recognized.
Attachment #8615248 - Flags: review?(gps)
Attachment #8615248 - Flags: review?(gps) → review+
Comment on attachment 8615248 [details]
MozReview Request: reviewboard: add warning for unrecognized review (bug 1164127); r?gps

https://reviewboard.mozilla.org/r/10219/#review8955

This is good. It would be great if we could display things next to the commit with issues. But that can be a follow-up.

Hint: we'll want to transfer the assigned reviewers down as metadata/lines in the review response so we can display them next to the commit. When we do that, we can add an "unrecognized reviewers" entry as well.
Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/f95ef3ee11d2

I'm leaving this open with a lower priority to do the follow on work that gps suggested.
Status: NEW → ASSIGNED
Priority: P1 → P3
Blocks: 1212358
Since we don't support partially landed series, a new bug would have to be filed for this anyway.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.