1164127 - The hg client should warn if unrecognized users are in the "r?<nick>" string in the commit message

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Dan Minor [:dminor]]

Bug 1142251 is going to add the capability to specify reviewers in commit message. It would be nice if the mercurial client warned the user if one of the specified reviewers is not recognized as a valid user.

Comment 1

[Dan Minor [:dminor]]

We're getting bugs filed against reviewer detection and currently have no way to identify what is going wrong. Fixing this might be the best way ahead.

Comment 2

[Dan Minor [:dminor]]

Attachment: MozReview Request: reviewboard: add warning for unrecognized review (bug 1164127); r?gps

reviewboard: add warning for unrecognized review (bug 1164127); r?gps

This adds a warning to the user if the reviewer specified for review using the
r? syntax is not recognized.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8615248 [details]
MozReview Request: reviewboard: add warning for unrecognized review (bug 1164127); r?gps

https://reviewboard.mozilla.org/r/10219/#review8955

This is good. It would be great if we could display things next to the commit with issues. But that can be a follow-up.

Hint: we'll want to transfer the assigned reviewers down as metadata/lines in the review response so we can display them next to the commit. When we do that, we can add an "unrecognized reviewers" entry as well.

Comment 4

[Dan Minor [:dminor]]

Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/f95ef3ee11d2

I'm leaving this open with a lower priority to do the follow on work that gps suggested.

Comment 5

[Dan Minor [:dminor]]

Since we don't support partially landed series, a new bug would have to be filed for this anyway.