Closed Bug 1164132 Opened 9 years ago Closed 6 years ago

Reviewers specified in UI should not be lost when an amended commit is pushed with reviewers in the summary

Categories

(MozReview Graveyard :: General, defect, P3)

Product:
MozReview Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: dminor, Unassigned)

References

Details

Bug 1142251 is going to add the capability to specify reviewers in commit message. If reviewers are manually added to a commit and then the commit is amended and pushed again, the manually added users are lost. (If the commit is unchanged, the manually added reviewers are retained.)

If for some reason it's not possible to specify someone on the command line, forcing them to be added manually each time the commit is amended and pushed is going to be annoying.

On the other hand, it's possible that the amended commit is specifying different reviewers on purpose, in which case having to remove a manually added reviewer after a push is also going to be annoying.
Product: Developer Services → MozReview
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.