116422 - MLK: Memory leak of 22 bytes from 1 block allocated in PR_Malloc

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Navin Gupta]

Cancelling a news message leaks here....

        Distribution of leaked blocks
        Allocation location
        malloc         [dbgheap.c:129]
        PR_Malloc      [prmem.c:54]
        msg_extract_Header_address_mailboxes [nsMsgHeaderParser.cpp:1027]
                size += j + 2;
            }
        
     =>     result = (char*)PR_Malloc(size + 1);
            if (!result)
                        {
                            PR_Free(addrs);
                nsMsgHeaderParser::ExtractHeaderAddressMailboxes(char 
const*,char const*,char * *) [nsMsgHeaderParser.cpp:205]
                          (void) NS_ConvertUTF8toUCS2(line).get(); // asserts if 
invalid UTF-8
                    #endif
                    
                 =>     *mailboxes = msg_extract_Header_address_mailboxes(line);
                        return NS_OK;
                      }
                      else
                nsNNTPProtocol::CheckIfAuthor(nsISupports *,void *) 
[nsNNTPProtocol.cpp:4248]
                    
                        char *us = nsnull;
                        char *them = nsnull;
                 =>     nsresult rv1 = 
parser->ExtractHeaderAddressMailboxes(nsnull, cancelInfo->from, &us);
                        nsresult rv2 = 
parser->ExtractHeaderAddressMailboxes(nsnull, cancelInfo->old_from, &them);
                    
                        PR_LOG(NNTP,PR_LOG_ALWAYS,("us = %s, them = %s", us, 
them));
                nsSupportsArray::EnumerateForwards((*)(nsISupports *,void 
*),void *) [nsSupportsArray.cpp:684]
                      PRBool  running = PR_TRUE;
                    
                      while (running && (++aIndex < (PRInt32)mCount)) {
                 =>     running = (*aFunc)(mArray[aIndex], aData);
                      }
                      return running;
                    }
                nsNNTPProtocol::DoCancel(void) [nsNNTPProtocol.cpp:4361]
                              if (NS_FAILED(rv)) return -1;
                    
                              // CheckIfAuthor will set cancelInfo.from if a 
match is found
                 =>           identities->EnumerateForwards(CheckIfAuthor, (void 
*)&cancelInfo);
                          }
                    
                          if (!cancelInfo.from) {
                nsNNTPProtocol::ProcessProtocolState(nsIURI *,nsIInputStream 
*,UINT,UINT) [nsNNTPProtocol.cpp:5267]
                nsMsgProtocol::OnDataAvailable(nsIRequest *,nsISupports 
*,nsIInputStream *,UINT,UINT) [nsMsgProtocol.cpp:262]
                nsOnDataAvailableEvent::HandleEvent(void) 
[nsStreamListenerProxy.cpp:193]

Comment 1

[Navin Gupta]

Attachment: proposed fix

free 'us' and 'them'.

Comment 2

[Navin Gupta]

Attachment: proposed fix

use nsXPIDLCString for 'us' and 'them'

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 62568 [details] [diff] [review]
proposed fix

sr=sspitzer

does the PR_LOG() still do the right thing?

Comment 4

[Navin Gupta]

fixed PR_LOG as well

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Nice work, thanks for filing/fixing this.

Verified FIXED using Windows 2000, latest trunk build as of 2:30 pm 12-31-2001, 
running Purify.