Rubbish return value in ActorsParent.cpp

RESOLVED FIXED in Firefox 39, Firefox OS v2.2

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mt, Assigned: mt)

Tracking

39 Branch
mozilla39
Points:
---

Firefox Tracking Flags

(firefox38.0.5 unaffected, firefox39 fixed, firefox40 unaffected, firefox41 unaffected, firefox-esr38 fixed, b2g-v2.2 fixed, b2g-master unaffected)

Details

(URL)

Attachments

(1 attachment)

1003 bytes, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

3 years ago
nullptr isn't a valid value for bool

Modern compilers don't even compile that sort of thing.
(Assignee)

Comment 1

3 years ago
Created attachment 8604900 [details] [diff] [review]
false.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1155634
[User impact if declined]: Beta doesn't build for some people
[Describe test coverage new/current, TreeHerder]: compilation, testing in progress
[Risks and why]: nullptr coerces to false, so this should be a non-change
[String/UUID change made/needed]: none
Attachment #8604900 - Flags: review?(bent.mozilla)
Attachment #8604900 - Flags: approval-mozilla-beta?
(Assignee)

Updated

3 years ago
Blocks: 1155634
Attachment #8604900 - Flags: review?(bent.mozilla) → review+
Thanks!
Martin, is 39 the only version affected here?
Flags: needinfo?(martin.thomson)
(Assignee)

Comment 4

3 years ago
I didn't find it on 41 (m-c).
38.0.5 (release) is OK.
40 (aurora) is OK.
Flags: needinfo?(martin.thomson)
Thanks for checking!
status-firefox38.0.5: --- → unaffected
status-firefox39: --- → affected
status-firefox40: --- → unaffected
status-firefox41: --- → unaffected
Comment on attachment 8604900 [details] [diff] [review]
false.patch

Approved for uplift to beta (39) to fix a recent regression that caused build issues for 39 only.
Attachment #8604900 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/bf701a33867c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

3 years ago
I need to apologize for getting the a= slightly wrong here.  Sorry Liz.
Assignee: nobody → martin.thomson
status-firefox39: affected → fixed
Target Milestone: --- → mozilla39
status-b2g-v2.2: --- → affected
status-b2g-master: --- → unaffected
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/450cb9a3222b
status-b2g-v2.2: affected → fixed
Comment on attachment 8604900 [details] [diff] [review]
false.patch

Needed for esr38 as we also took bug 1155634
Attachment #8604900 - Flags: approval-mozilla-esr38+
status-firefox-esr38: --- → affected
I folded the fix for this into the esr38 uplift of bug 1155634.
status-firefox-esr38: affected → fixed
You need to log in before you can comment on or make changes to this bug.