Closed Bug 1164232 Opened 5 years ago Closed 5 years ago
Rubbish return value in Actors
nullptr isn't a valid value for bool Modern compilers don't even compile that sort of thing.
Approval Request Comment [Feature/regressing bug #]: Bug 1155634 [User impact if declined]: Beta doesn't build for some people [Describe test coverage new/current, TreeHerder]: compilation, testing in progress [Risks and why]: nullptr coerces to false, so this should be a non-change [String/UUID change made/needed]: none
Attachment #8604900 - Flags: review?(bent.mozilla) → review+
Martin, is 39 the only version affected here?
I didn't find it on 41 (m-c). 38.0.5 (release) is OK. 40 (aurora) is OK.
Thanks for checking!
Comment on attachment 8604900 [details] [diff] [review] false.patch Approved for uplift to beta (39) to fix a recent regression that caused build issues for 39 only.
Attachment #8604900 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
I need to apologize for getting the a= slightly wrong here. Sorry Liz.
Comment on attachment 8604900 [details] [diff] [review] false.patch Needed for esr38 as we also took bug 1155634
Attachment #8604900 - Flags: approval-mozilla-esr38+
I folded the fix for this into the esr38 uplift of bug 1155634.
You need to log in before you can comment on or make changes to this bug.