Closed
Bug 1164232
Opened 11 years ago
Closed 11 years ago
Rubbish return value in ActorsParent.cpp
Categories
(Core :: Storage: IndexedDB, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox38.0.5 | --- | unaffected |
| firefox39 | --- | fixed |
| firefox40 | --- | unaffected |
| firefox41 | --- | unaffected |
| firefox-esr38 | --- | fixed |
| b2g-v2.2 | --- | fixed |
| b2g-master | --- | unaffected |
People
(Reporter: mt, Assigned: mt)
References
()
Details
Attachments
(1 file)
|
1003 bytes,
patch
|
bent.mozilla
:
review+
lizzard
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-esr38+
|
Details | Diff | Splinter Review |
nullptr isn't a valid value for bool
Modern compilers don't even compile that sort of thing.
|
Assignee | |
Comment 1•11 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: Bug 1155634
[User impact if declined]: Beta doesn't build for some people
[Describe test coverage new/current, TreeHerder]: compilation, testing in progress
[Risks and why]: nullptr coerces to false, so this should be a non-change
[String/UUID change made/needed]: none
Attachment #8604900 -
Flags: review?(bent.mozilla)
Attachment #8604900 -
Flags: approval-mozilla-beta?
|
||
Updated•11 years ago
|
Attachment #8604900 -
Flags: review?(bent.mozilla) → review+
Thanks!
|
||
Comment 3•11 years ago
|
||
Martin, is 39 the only version affected here?
Flags: needinfo?(martin.thomson)
|
|
Assignee | |
Comment 4•11 years ago
|
||
I didn't find it on 41 (m-c).
38.0.5 (release) is OK.
40 (aurora) is OK.
Flags: needinfo?(martin.thomson)
|
|
||
Comment 5•11 years ago
|
||
Thanks for checking!
status-firefox38.0.5:
--- → unaffected
status-firefox39:
--- → affected
status-firefox40:
--- → unaffected
status-firefox41:
--- → unaffected
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8604900 [details] [diff] [review]
false.patch
Approved for uplift to beta (39) to fix a recent regression that caused build issues for 39 only.
Attachment #8604900 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•11 years ago
|
||
I need to apologize for getting the a= slightly wrong here. Sorry Liz.
|
||
Updated•11 years ago
|
Assignee: nobody → martin.thomson
Target Milestone: --- → mozilla39
|
|
||
Updated•11 years ago
|
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → unaffected
|
|
||
Comment 9•11 years ago
|
||
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8604900 [details] [diff] [review]
false.patch
Needed for esr38 as we also took bug 1155634
Attachment #8604900 -
Flags: approval-mozilla-esr38+
|
|
||
Updated•11 years ago
|
status-firefox-esr38:
--- → affected
|
|
||
Comment 11•11 years ago
|
||
I folded the fix for this into the esr38 uplift of bug 1155634.
You need to log in
before you can comment on or make changes to this bug.
Description
•