1164253 - Save request is sent twice for every button press

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Nate Weiner]

For each save with the toolbar button, two save requests are being sent to the server. 

The second save is happening when the panel closes, so I'm assuming this is a regression that we didn't catch caused by the last minute changes to event handling over the weekend. 

Steps to reproduce:
1. Open the Browser Toolbox
2. Switch to the Network tab
3. Click the Pocket button in the toolbar
4. Note in the network log that a save request shows
5. Click in the window to dismiss the Pocket panel
6. Note in the network log a second save request goes out when the panel closes

Marking as a P1 as this is not going to be very nice to our servers :)

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

*cough* Mea culpa.

Towards the end of bug 1163319 I renamed a "onPanelLoaded" function to "onFrameLoaded" to better reflect what was happening, but missed a rename. And so we're not actually removing the event listener. Oops.

[The iframe's @src is being set to about:blank when the panel closes, and the load event from that is what's causing the second call.]

Comment 2

[Nate Weiner]

Applied the patch, built, tested, confirmed fixed. 

Come on Dolske, it's like you were writing last-minute code at 10pm on a Saturday night and didn't have anyone to back you up to help test a bug you'd only notice if you had the network console open ;)

Thanks for the quick fix.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8604996 [details] [diff] [review]
Patch v.1

Review of attachment 8604996 [details] [diff] [review]:
-----------------------------------------------------------------

D'oh, guess I missed it in my review as well.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/494fc85d8aef

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 8604996 [details] [diff] [review]
Patch v.1

[Triage Comment]

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.

Comment 6

[Justin Dolske [:Dolske]]

(aurora currently closed)
https://hg.mozilla.org/releases/mozilla-beta/rev/c2f420841c18
https://hg.mozilla.org/releases/mozilla-release/rev/89ef57a1733a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/494fc85d8aef

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2fc97db07f55

Comment 9

[Andrei Vaida [:avaida]]

Reproduced the bug with 38.0.5b1 (20150511143336), confirmed fixed on 38.0.5b3 (20150518141916).

Comment 10

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Already verified for Firefox 38.0.5. I don't think verification needs to be repeated for the other versions.