1164301 - Voice input in url activates on click and release

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

STR:
1) Click the url bar
2) Click and hold the mic icon

Expected: On release, voice input activates
Actual: Voice input activates several times a second

Comment 1

[Chenxia Liu [:liuche]]

I can't repro the "several times a second" bug anymore, although I do see the voice activation being activated on both press and release.

Comment 2

[Karim Benhmida [:karim]]

Attachment: Voice input in url activates on click and release

Comment 3

[Karim Benhmida [:karim]]

Comment on attachment 8608387 [details] [diff] [review]
Voice input in url activates on click and release

The Voice Recognizer now only launches on click (ACTION_DOWN). Tested on Galaxy Nexus, Nexus 7 and 9

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8608387 [details] [diff] [review]
Voice input in url activates on click and release

Review of attachment 8608387 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! You can fix the nit and then I'll land it for you.

::: mobile/android/base/toolbar/ToolbarEditText.java
@@ +722,5 @@
>  
>          @Override
>          public boolean onTouch(View v, MotionEvent event) {
>              boolean tapped;
> +            int action = event.getActionMasked();

Nit: make this final.

Comment 5

[Karim Benhmida [:karim]]

Attachment: Voice input in url activates on click and release

Comment 6

[Karim Benhmida [:karim]]

Comment on attachment 8608861 [details] [diff] [review]
Voice input in url activates on click and release

Fixed the nit

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a78534544347

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a78534544347

Comment 9

[Karim Benhmida [:karim]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79357f30e497