Bug 1105376 is a feature where we choose not to show tiles in the context of other sites' tiles. Bug 1159884 is trying a "simple" approach of hardcoding a list of sites where we check the top tiles against that list. We can reuse the tests from that bug to refactor to using SafeBrowsing. There's been multiple suggestions to use SafeBrowsing to allow for more dynamic updating. gcp, is it possible to use give SafeBrowsing a local list, e.g., data/resource/chrome URI? This doesn't provide the dynamic updates, but would allow us to start using the API and make it easier to switch to using a remotely hosted list. Are there tools we can use to convert a list of sites into a static file that we can package as part of Firefox to use with the SafeBrowsing API?
Our usage of the list would be to lookup if a given new tab tile is in the "negative adjacency db" and not for classifying urls on loading a page. So it looks like following the addMozEntries, we construct an update string and update "negative-adjacency-simple" then later to check.. dbservice = Cc["@mozilla.org/url-classifier/dbservice;1"].getService(Ci.nsIUrlClassifierDBService); dbservice.lookup(url converted to principal, "negative-adjacency-simple", cb) maksik, looks like we'll need to make sure the negative adjacency code is structured to allow async checks/lookups.
(In reply to Ed Lee :Mardak from comment #2) > maksik, looks like we'll need to make sure the negative adjacency code is > structured to allow async checks/lookups. If you don't need to "double-check" the SafeBrowsing entries vs a remote sever, then you can use this: https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsIURIClassifier.idl#63 (It's also what Tracking Protection uses)
Oh neat. We probably could use classifyLocalWithTables which is synchronous and can limit to the negative adjacency table. https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsIURIClassifier.idl#66
(In reply to Ed Lee :Mardak from comment #2) > So it looks like following the addMozEntries, we construct an update string > and update "negative-adjacency-simple" then later to check.. BTW, the naming convention is: organization-listtype-format So far we've used "mozpub-*-*" for our own lists (tracking protection and shumway). Unless you have a reason for using something else, I'd suggest something along the lines of "mozpub-negadjacency-simple"
Assignee: nobody → mzhilyaev
Iteration: --- → 41.3 - Jun 29
Summary: Use SafeBrowsing to power negative adjacency matching → Use SafeBrowsing to power ubadjainncy matching
Summary: Use SafeBrowsing to power ubadjainncy matching → Use SafeBrowsing to power inadjacency matching
I don't believe this is required anymore given we no longer have sponsored tiles.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.