1164426 - Build blocklist of sites where we do not want to offer reader mode into toolkit isProbablyReaderable invocation

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[:Gijs (out for now; he/him)]

Prime candidates:

twitter.com
reddit.com
github.com
mail.google.com (I occasionally see reader mode icons on gmail... I've not had time to investigate, but it's definitely not useful, and wrong)

Comment 1

[:Gijs (out for now; he/him)]

Attachment: MozReview Request: bz://1164426/Gijs

/r/8795 - Bug 1164426 - build reader mode blocklist, r?margaret

Pull down this commit:

hg pull -r e1f055e136ba52d15d682a02bf0bcfc5255fe1b4 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[:Margaret Leibovic]

https://reviewboard.mozilla.org/r/8795/#review7483

This will affect mobile as well, but I don't think there are any sites where we would want different behvaior for desktop/mobile.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8606044 [details]
MozReview Request: bz://1164426/Gijs

https://reviewboard.mozilla.org/r/8793/#review7485

Ship It!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/353afeed8cf2

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8606044 [details]
MozReview Request: bz://1164426/Gijs

Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: spurious reader mode offers
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, simple change
[String/UUID change made/needed]: no

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/353afeed8cf2

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8606044 [details]
MozReview Request: bz://1164426/Gijs

Should be in 38.0.5b3.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3abaf0259599

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/740cf3ad1c52

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/6ec85b777880

Comment 11

[Andrei Vaida [:avaida]]

Confirmed fixed on 38.0.5b3 (20150518141916), using Ubuntu 14.04 (x64) and Mac OS X 10.9.5 with several pages from the domains mentioned in Comment 0.

Comment 12

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Removing qe-verify+ since verification on 38.0.5 Beta should suffice.

Comment 14

[:Gijs (out for now; he/him)]

Attachment: MozReview Request: Bug 1164426 - build reader mode blocklist, r?margaret