Build blocklist of sites where we do not want to offer reader mode into toolkit isProbablyReaderable invocation

VERIFIED FIXED in Firefox 38.0.5

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks 1 bug)

Trunk
mozilla41
Points:
3
Bug Flags:
firefox-backlog +
in-testsuite -

Firefox Tracking Flags

(firefox38.0.5 verified, firefox39 fixed, firefox40 fixed, firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Prime candidates:

twitter.com
reddit.com
github.com
mail.google.com (I occasionally see reader mode icons on gmail... I've not had time to investigate, but it's definitely not useful, and wrong)
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
/r/8795 - Bug 1164426 - build reader mode blocklist, r?margaret

Pull down this commit:

hg pull -r e1f055e136ba52d15d682a02bf0bcfc5255fe1b4 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606044 - Flags: review?(margaret.leibovic)
https://reviewboard.mozilla.org/r/8795/#review7483

This will affect mobile as well, but I don't think there are any sites where we would want different behvaior for desktop/mobile.
Comment on attachment 8606044 [details]
MozReview Request: bz://1164426/Gijs

https://reviewboard.mozilla.org/r/8793/#review7485

Ship It!
Attachment #8606044 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 8606044 [details]
MozReview Request: bz://1164426/Gijs

Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: spurious reader mode offers
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, simple change
[String/UUID change made/needed]: no
Attachment #8606044 - Flags: approval-mozilla-release?
Attachment #8606044 - Flags: approval-mozilla-beta?
Attachment #8606044 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/353afeed8cf2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8606044 [details]
MozReview Request: bz://1164426/Gijs

Should be in 38.0.5b3.
Attachment #8606044 - Flags: approval-mozilla-release?
Attachment #8606044 - Flags: approval-mozilla-release+
Attachment #8606044 - Flags: approval-mozilla-beta?
Attachment #8606044 - Flags: approval-mozilla-beta+
Attachment #8606044 - Flags: approval-mozilla-aurora?
Attachment #8606044 - Flags: approval-mozilla-aurora+
Confirmed fixed on 38.0.5b3 (20150518141916), using Ubuntu 14.04 (x64) and Mac OS X 10.9.5 with several pages from the domains mentioned in Comment 0.
Status: RESOLVED → VERIFIED
QA Contact: andrei.vaida
Removing qe-verify+ since verification on 38.0.5 Beta should suffice.
Flags: qe-verify+
(Assignee)

Comment 13

4 years ago
Attachment #8606044 - Attachment is obsolete: true
Attachment #8620281 - Flags: review+
You need to log in before you can comment on or make changes to this bug.