Closed Bug 1164453 Opened 7 years ago Closed 7 years ago
crash in mozilla::Media
Codec Data Decoder::Init Decoder(mozilla::jni::Ref<mozilla::widget::sdk::Surface> const&)
This bug was filed from the Socorro interface and is report bp-b7847bd6-ae67-42f5-b98b-3936f2150512. =============================================================
Looks like mCallback is null, which isn't supposed to happen. Eugen, can you look into how/why this could happen? Maybe adding an assertion that aCallback is non-null would be good too.
Assignee: nobody → esawin
The callback can be set to null in some cases (e.g. ), we should always check before calling functions on it.  https://dxr.mozilla.org/mozilla-central/source/dom/media/fmp4/MP4Reader.cpp#99
There are cases where mCallback can be unset (initialization) and others where it must be set (decoding), we should check/assert accordingly.
Attachment #8606359 - Flags: review?(snorp)
Bug 1160321 has rendered my link in comment 2 obsolete (see https://hg.mozilla.org/mozilla-central/diff/03dc784d5456/dom/media/fmp4/MP4Reader.cpp).
Attachment #8606359 - Flags: review?(snorp) → review+
My assumption that we only initialize the decoder without a callback was wrong. We also do it in places () which eventually call into the decoder loop. That means, we can never assume that the callback is set. Also, sorry for introducing a new macro, but sporadic variadic function support in templates may currently cause us issues on some platforms/compiler versions.  https://dxr.mozilla.org/mozilla-central/source/dom/media/fmp4/MP4Decoder.cpp#276
Attachment #8606487 - Flags: review?(snorp) → review+
You need to log in before you can comment on or make changes to this bug.