1164486 - Application is leaking Browser instances

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I added a a deinit to Browser:

    deinit {
        println("Hi! I am deinit!")
    }

But it is never called. Which means we are leaking Browser instances and thus also WKWebView instances.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think the actual problem is that we are holding a reference to the Browser.webView somewhere.

The Browser is a WKScriptMessageHandler so it's WKWebView has a reference to Browser. That is fine because the webview is released when the Browser is released. But! If something outside of Browser is keeping a reference to the WKWebView then that release will not happen.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This also contributes to the startup time I think, according to WebKit bug https://bugs.webkit.org/show_bug.cgi?id=142583

Comment 3

[Richard Newman [:rnewman]]

WKScriptMessage.initWithBody:webView:frameInfo:name leaks an NSDictionary each time we open a new tab.

I can't see what's in that dict, but perhaps it's the WKSMH…

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/521

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8612625 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/521

Great fix.

Comment 6

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/e00109f05a873867ed48a0ba3391b6b99fe2fb5f