1164646 - Share and Bookmark icons are larger than the rest of the nav icons

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Robin Andersen [:tecgirl]]

Attachment: iOS Simulator Screen Shot May 13, 2015, 1.39.05 PM.png

using today's master (Build 15), the Share and Bookmark icons are too large. They should balance the vertical height of the other icons.

Comment 1

[Robin Andersen [:tecgirl]]

Attachment: iOS Simulator Screen Shot May 13, 2015, 2.26.31 PM.png

Update, it looks as if Share and Bookmark are displaying normally, and the Nav icons have been manually adjusted. We should replace these icons with correctly-sized assets (and confirm Universal indeed works on iPad).

Comment 2

[Robin Andersen [:tecgirl]]

Update #2, these icons show large after rotation (portrait > landscape > portrait)

Comment 3

[Robin Andersen [:tecgirl]]

possibly related to bug 	1162268

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/534

I tried several approaches to this, including implementing callbacks to have an opportunity to change the buttons `contentEdgeInsets` property based on the current `UITraitCollection`.

But .. I decided that was all too complicated. The actual problem here is that we should not use the `contentEdgeInsets` to scale the button images. It is the wrong approach.

So what I have done is simply remove the calls where we change the `contentEdgeInsets`. This means that this is now an asset problem. The icons are obviously a bit too big currently so I will file a new bug to ask for two icon sets (or one set with a scale factor for when we display them in the bottom bar - which I think displays a smaller version).

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8613673 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/534

I agree - this is much better. Makes more sense for the images to just be the correct size instead of trying to smoosh them into place.