updating an attachment with pre-existing review requests shouldn't enforce the "last logged in to bugzilla" limit

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Review
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
updating an attachment with pre-existing review requests shouldn't enforce the "last logged in to bugzilla" limit.


right now if you edit an attachment that has an existing review directed at someone who hasn't logged into bugzilla, you're unable to save any changes to that attachment.

the restriction imposed by bug 751862 should only impact new requests, not existing ones.
(Assignee)

Comment 1

3 years ago
Created attachment 8605706 [details] [diff] [review]
1164780_1.patch

- perform review checks on added flags instead of all flags
Attachment #8605706 - Flags: review?(dkl)
Comment on attachment 8605706 [details] [diff] [review]
1164780_1.patch

Review of attachment 8605706 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8605706 - Flags: review?(dkl) → review+
(Assignee)

Comment 3

3 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   9ed5276..4bc64fd  master -> master
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.