1164790 - [RTL][Settings]The "+" symbol is shown at wrong side of number in Authorized numbers list of FDN.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Sue]

Attachment: Authorized numbers view.png

[1.Description]:
[RTL][Flame v2.2&v3.0][Nexus 5 2.2&3.0][Settings]The "+" symbol is shown at right side of phone number in Authorized numbers list of FDN.
See attachment:Authorized numbers view.png

[2.Testing Steps]: 
Prerequisite: Insert a SIM card.
1. Set system language as Arabic.
2. Launch Settings.
3. Tap Call Settings -> SIM 1 -> Fixed Dialing Numbers -> Authorized numbers.
4. Tap "Add" button and add a contact with "+" in number.(Such as "[phone]")
5. Observe the "Authorized numbers" view.

[3.Expected Result]: 
5. The "+" symbol should be shown at left side of phone number.

[4.Actual Result]: 
5. The "+" symbol is shown at right side of phone number.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150513002507
Gaia Revision          e048df68f6f4853b5826a8816e143d95258149de
Gaia Date              2015-05-12 19:10:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0e6b4aab2b94
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150513.041549
Firmware Date          Wed May 13 04:15:58 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150513160203
Gaia Revision          338f66e6a96491d2f5854b188c6b141ceb690d97
Gaia Date              2015-05-13 14:08:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1fab94ad196c
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150513.193307
Firmware Date          Wed May 13 19:33:19 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150513002507
Gaia Revision          e048df68f6f4853b5826a8816e143d95258149de
Gaia Date              2015-05-12 19:10:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0e6b4aab2b94
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150513.041202
Firmware Date          Wed May 13 04:12:17 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (affected)
Build ID               20150513010202
Gaia Revision          0d6c04f13fd385bda045f4e539b2a67cb5d84b1d
Gaia Date              2015-05-12 17:07:06
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/62d9b117c688
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150513.044441
Firmware Date          Wed May 13 04:44:56 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Triage: P3

Comment 2

[Alissa（leave from Mozilla）]

This issue can be reproduced on latest build of AriesKK_v2.5.
Rate:5/5
Device:AriesKK_V2.5
Build ID               20150811234258
Gaia Revision          c7875bbc8b32e7b95cc55c9690b03b140905d84d
Gaia Date              2015-08-11 18:18:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d4f3a8a75577e4af2914a4e899ca2e724f9715c4
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150811.230622
Firmware Date          Tue Aug 11 23:06:29 UTC 2015
Bootloader             s1

Comment 3

[Alissa（leave from Mozilla）]

Attachment: AriesKK_v2.5.png

Comment 4

[Lancy(Leave from Mozilla)]

This issue still can be reproduced on latest AriesKK&FlameKK v2.5 build.
FlameKK v2.5 (512mb)Build ID:20151101150206
AriesKK v2.5 Build ID:20151101012023

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1164790-fdn_plus_misplaced > mozilla-b2g:master

Comment 6

[Augustin Trancart [:autra]]

Comment on attachment 8684943 [details] [review]
[gaia] Phoxygen:bug1164790-fdn_plus_misplaced > mozilla-b2g:master

Hi Evelyn,

Please r?

Comment 7

[[e-mail]]

Comment on attachment 8684943 [details] [review]
[gaia] Phoxygen:bug1164790-fdn_plus_misplaced > mozilla-b2g:master

thanks

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/a9fedb240c49abe78859f6df49ebfef28e80b38c

Comment 9

[Augustin Trancart [:autra]]

Comment on attachment 8684943 [details] [review]
[gaia] Phoxygen:bug1164790-fdn_plus_misplaced > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 
[User impact] if declined: Poor rtl support
[Testing completed]: flame master
[Risk to taking this patch] (and alternatives if risky): low, only dir="auto" added
[String changes made]: none

Comment 10

[Mahendra Potharaju [:mahe]]

Comment on attachment 8684943 [details] [review]
[gaia] Phoxygen:bug1164790-fdn_plus_misplaced > mozilla-b2g:master

 Approved for 2.5 uplift. 

Thanks

Comment 11

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/0fd939b0a22e293caa8629a2647c668248c01384

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5&master and Aries KK 2.5&master by the STR in comment 0.

Actual results: The "+" symbol is shown at left side of number in Authorized numbers list of FDN.
See attachment: verified_Flame_2.5&master.png
Reproduce rate: 0/10


Device: Flame KK master_512mb (Pass)
Build ID               20151130150225
Gaia Revision          702773bee0b70e479ccebe5e061f571e977bc376
Gaia Date              2015-11-30 02:51:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a18630f9ab42ddfde03ba8c7757a42069c48c7ed
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151130.184457
Firmware Date          Mon Nov 30 18:45:12 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151130132518
Gaia Revision          702773bee0b70e479ccebe5e061f571e977bc376
Gaia Date              2015-11-30 02:51:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a18630f9ab42ddfde03ba8c7757a42069c48c7ed
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151130.124429
Firmware Date          Mon Nov 30 12:44:37 UTC 2015
Bootloader             s1

Device: Flame KK 2.5_512mb (Pass)
Build ID               20151130173516
Gaia Revision          391bcad1b3b427f189f4c7f11858fc739574682e
Gaia Date              2015-11-30 15:51:31
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1a022b4b67446b50f36c098aa425c65782af9066
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151130.164630
Firmware Date          Mon Nov 30 16:46:40 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151130171620
Gaia Revision          391bcad1b3b427f189f4c7f11858fc739574682e
Gaia Date              2015-11-30 15:51:31
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1a022b4b67446b50f36c098aa425c65782af9066
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151130.164746
Firmware Date          Mon Nov 30 16:47:54 UTC 2015
Bootloader             s1

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5&master.png