Closed Bug 1164821 Opened 9 years ago Closed 9 years ago

Remove previous workarounds for not having FxA keys in LoopRooms - remove old code to cope with unencrypted rooms

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
mozilla41
Iteration:
41.1 - May 25
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Now that we have encryption fully in place (especially after bug 1152764), we can remove some of the old workarounds that we've got around handling not having keys, and being able to save rooms in unencrypted format.
Depends on bug 1152764, removes the obsolete code, XXXs and tidies a few things up.
Attachment #8605795 - Flags: review?(mdeboer)
Comment on attachment 8605795 [details] [diff] [review]
Remove previous workarounds for not having FxA keys in LoopRooms - remove old code to cope with unencrypted rooms.

Review of attachment 8605795 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! This can land right after bug 1152764 is done.
Attachment #8605795 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/70f56bc3f50d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8605795 [details] [diff] [review]
Remove previous workarounds for not having FxA keys in LoopRooms - remove old code to cope with unencrypted rooms.

Approval Request Comment
[Feature/regressing bug #]: Context in Conversations for Hello
[User impact if declined]: This is a tidy-up patch for the context work for hacks and work arounds we had in place whilst we were still building up the system. It also simplifies the code and removes old fallbacks. Whilst there's no actual user impact, I'd be a lot more comfortable with the context work shipping with these clean ups.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, has unit tests.
[Risks and why]: Low - code changed covered by unit tests.
[String/UUID change made/needed]: None

This bug depends on bug 1152764.
Attachment #8605795 - Flags: approval-mozilla-aurora?
Attachment #8605795 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(standard8)
Flags: needinfo?(standard8)
You need to log in before you can comment on or make changes to this bug.